New issue
Advanced search Search tips

Issue 684189 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

unify temperature measurement in autotest and GLBench

Project Member Reported by ihf@chromium.org, Jan 24 2017

Issue description

On some more recent devices the temperature measurements used for throttling have diverged. Unify both paths.

01/22 01:59:19.942 DEBUG|        base_utils:0280| [stdout] Bench: Cooled down to 27.6'C (initial=27.5'C) after waiting 0.0s.
01/22 01:59:19.942 DEBUG|        base_utils:0280| [stdout] @RESULT: fbofill_tex_bilinear_128                      =    4448.73 mpixels_sec     [fbofill_tex_bilinear_128.pixmd5-ace50e9951333e8fb0a42dc7aa48b482.png]
01/22 01:59:19.943 DEBUG|        base_utils:0280| [stdout] Bench: Cooled down to 27.6'C (initial=27.5'C) after waiting 0.0s.
01/22 01:59:19.943 DEBUG|        base_utils:0280| [stdout] @RESULT: fbofill_tex_bilinear_256                      =   12100.17 mpixels_sec     [fbofill_tex_bilinear_256.pixmd5-1bf2ba5ee3c8c3b29b32aca5a9fe3f5d.png]
01/22 01:59:20.995 INFO |              perf:0110| PerfControl CPU temperature = 53.8
01/22 01:59:22.170 INFO |              perf:0110| PerfControl CPU temperature = 52.3
01/22 01:59:23.346 INFO |              perf:0110| PerfControl CPU temperature = 52.7
[...]
01/22 01:59:36.283 INFO |              perf:0110| PerfControl CPU temperature = 50.4
01/22 01:59:37.470 INFO |              perf:0110| PerfControl CPU temperature = 58.2
01/22 01:59:38.654 INFO |              perf:0110| PerfControl CPU temperature = 62.0
01/22 01:59:39.400 DEBUG|        base_utils:0280| [stdout] Bench: Cooled down to 27.6'C (initial=27.5'C) after waiting 0.0s.
01/22 01:59:39.400 DEBUG|        base_utils:0280| [stdout] @RESULT: fbofill_tex_bilinear_512                      =   16776.86 mpixels_sec     [fbofill_tex_bilinear_512.pixmd5-dfe2a7b942b3d7fe83ba2da0ec08c513.png]
01/22 01:59:39.401 DEBUG|        base_utils:0280| [stdout] Bench: Cooled down to 27.7'C (initial=27.5'C) after waiting 0.0s.
01/22 01:59:39.401 DEBUG|        base_utils:0280| [stdout] @RESULT: fbofill_tex_bilinear_1024   
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c5e14be9b5a38349bb10c3ea7625353aae62da38

commit c5e14be9b5a38349bb10c3ea7625353aae62da38
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Tue Jan 24 07:04:18 2017

glbench: add temperature sensor paths for kevin/elm.

This is a workaround. A better fix will consist in calling
a helper python script which calls
autotest/bin/site_utils.py:def get_current_temperature_max()

BUG= chromium:684189 
TEST=None

Change-Id: I7f61b4f6b3c18c721716021ba9a9f08df53b8b5b
Reviewed-on: https://chromium-review.googlesource.com/430859
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Haixia Shi <hshi@chromium.org>

[modify] https://crrev.com/c5e14be9b5a38349bb10c3ea7625353aae62da38/client/deps/glbench/src/utils.cc

Comment 3 by ihf@chromium.org, Jan 27 2017

We had one good run.
https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=421505011

The machine came in fairly hot, so it didn't try to cool too much. But it did wait 1-2s between each subtests and never. No higher temperature than 46'C was observed (before 62'C). Should be better now.

Bench: Cooled down to 45.1'C (initial=40.0'C) after waiting 1.0s.
@RESULT: texture_upload_luminance_teximage2d_2048      =    5151.53 mtexel_sec      [none]
Bench: Cooled down to 42.7'C (initial=40.0'C) after waiting 2.0s.
@RESULT: texture_upload_luminance_texsubimage2d_32     =     645.18 mtexel_sec      [none]

Comment 4 by ihf@chromium.org, Jan 27 2017

I should still unify both measurement paths. So not closing.

Comment 5 by ihf@chromium.org, May 5 2017

Owner: pwang@chromium.org

Comment 6 by pwang@chromium.org, May 5 2017

I am currently OOO for graduation in May/5. Would try to find a way to unify once I am back. 
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6dadbab63a63cce477b7dab505fa852a97903b05

commit 6dadbab63a63cce477b7dab505fa852a97903b05
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Fri Jun 02 06:49:34 2017

temperature.py: unify temperature measurement

Unify measurement of temperature in autotest and GLBench
Now GLBench calls autotest/bin/temperature.py to get the
temperature measurement from autotest utils.py

1) Add temperature.py to client/bin
   Usage: temperature.py [-h] [-m | -c] [-v]
2) Modify glbench/utils.cc to use temperature.py for
   temperature measurement

BUG= chromium:684189 
TEST=test_that graphics_GLBench, glbench

Change-Id: Icbba61d783cd530817a1049805969866326bdda8
Reviewed-on: https://chromium-review.googlesource.com/499155
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/6dadbab63a63cce477b7dab505fa852a97903b05/client/site_tests/graphics_GLBench/graphics_GLBench.py
[modify] https://crrev.com/6dadbab63a63cce477b7dab505fa852a97903b05/client/deps/glbench/src/utils.cc
[add] https://crrev.com/6dadbab63a63cce477b7dab505fa852a97903b05/client/bin/temperature.py

Comment 8 by pwang@chromium.org, Jun 10 2017

Status: Fixed (was: Assigned)
Based on https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/122280488-chromeos-test/chromeos6-row21-rack2-host17/graphics_GLBench/ 
The temperature seems reasonable to me.

06/08 21:50:57.397 DEBUG|             utils:0298| [stdout] Bench: Cooled down to 59.0'C (initial=54.0'C) after waiting 4.8s.
06/08 21:50:57.397 DEBUG|             utils:0298| [stdout] @RESULT: texture_update_rgba_teximage2d_256            =    2866.77 mtexel_sec      [texture_update_rgba_teximage2d_256.pixmd5-20b8faaa96217834f4d7e7afce992b45.png]
06/08 21:50:57.397 DEBUG|             utils:0298| [stdout] Bench: Cooled down to 59.0'C (initial=54.0'C) after waiting 27.3s.
06/08 21:50:57.398 DEBUG|             utils:0298| [stdout] @RESULT: texture_update_rgba_teximage2d_512            =    3800.75 mtexel_sec      [texture_update_rgba_teximage2d_512.pixmd5-20b8faaa96217834f4d7e7afce992b45.png]
06/08 21:50:57.398 DEBUG|             utils:0298| [stdout] Bench: Cooled down to 59.0'C (initial=54.0'C) after waiting 7.1s.
06/08 21:50:57.398 DEBUG|             utils:0298| [stdout] @RESULT: texture_update_rgba_teximage2d_768            =    3380.47 mtexel_sec      [texture_update_rgba_teximage2d_768.pixmd5-20b8faaa96217834f4d7e7afce992b45.png]
06/08 21:50:57.398 DEBUG|             utils:0298| [stdout] Bench: Cooled down to 59.0'C (initial=54.0'C) after waiting 3.6s.
06/08 21:50:57.823 INFO |              perf:0110| PerfControl CPU temperature = 60.0
06/08 21:50:58.888 INFO |              perf:0110| PerfControl CPU temperature = 59.0
06/08 21:50:59.976 INFO |              perf:0110| PerfControl CPU temperature = 62.0
06/08 21:51:01.054 INFO |              perf:0110| PerfControl CPU temperature = 61.0
06/08 21:51:02.118 INFO |              perf:0110| PerfControl CPU temperature = 59.0
06/08 21:51:03.211 INFO |              perf:0110| PerfControl CPU temperature = 63.0

Comment 9 by ihf@chromium.org, Jun 13 2017

Status: Verified (was: Fixed)
Pretty hot (lab is warm these days), but reasonable. Thanks!

Sign in to add a comment