[Predator] Define predator-specific exception type. |
|||
Issue description[Predator] Define predator-specific exception type. Currently, predator is using ``Exception`` in many places, we will have better exception handling if we define predator-specific exception types.
,
Jun 1 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb commit 40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb Author: Cathal Weakliam <cweakliam@google.com> Date: Fri Jun 02 22:18:00 2017 Create a custom Predator-specific exception type. This CL defines the PredatorError exception, and replaces code that previously raised Exception to instead raise this more specific custom exception. PredatorError can be used as a base class to define more specific exceptions as needed. R=katesonia@google.com Bug: 684183 Change-Id: I8135398f2fef56674e3dfa3783d7ef831efedbe6 Reviewed-on: https://chromium-review.googlesource.com/522891 Commit-Queue: Cathal Weakliam <cweakliam@google.com> Reviewed-by: Sharu Jiang <katesonia@chromium.org> [modify] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/common/crash_pipeline.py [add] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/common/exceptions.py [modify] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/analysis/linear/training.py
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb commit 40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb Author: Cathal Weakliam <cweakliam@google.com> Date: Fri Jun 02 22:18:00 2017 Create a custom Predator-specific exception type. This CL defines the PredatorError exception, and replaces code that previously raised Exception to instead raise this more specific custom exception. PredatorError can be used as a base class to define more specific exceptions as needed. R=katesonia@google.com Bug: 684183 Change-Id: I8135398f2fef56674e3dfa3783d7ef831efedbe6 Reviewed-on: https://chromium-review.googlesource.com/522891 Commit-Queue: Cathal Weakliam <cweakliam@google.com> Reviewed-by: Sharu Jiang <katesonia@chromium.org> [modify] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/common/crash_pipeline.py [add] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/common/exceptions.py [modify] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/analysis/linear/training.py
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb commit 40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb Author: Cathal Weakliam <cweakliam@google.com> Date: Fri Jun 02 22:18:00 2017 Create a custom Predator-specific exception type. This CL defines the PredatorError exception, and replaces code that previously raised Exception to instead raise this more specific custom exception. PredatorError can be used as a base class to define more specific exceptions as needed. R=katesonia@google.com Bug: 684183 Change-Id: I8135398f2fef56674e3dfa3783d7ef831efedbe6 Reviewed-on: https://chromium-review.googlesource.com/522891 Commit-Queue: Cathal Weakliam <cweakliam@google.com> Reviewed-by: Sharu Jiang <katesonia@chromium.org> [modify] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/common/crash_pipeline.py [add] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/common/exceptions.py [modify] https://crrev.com/40157ffd0b7b1be25f028a5cc24fdba7cd77fbcb/appengine/predator/analysis/linear/training.py
,
Jul 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kateso...@chromium.org
, Jan 24 2017