Harmony - update Relaunch Chrome dialog |
||||||||
Issue descriptionChrome Version : 57.0.2984.0 On Cocoa Mac, it looks like the attached; a window-modal sheet. It's shown after selecting the 'Update Google Chrome' menu item from the Chrome App Menu.
,
Jan 26 2017
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28a279f9a121b7948b388257a43c79823bf311d6 commit 28a279f9a121b7948b388257a43c79823bf311d6 Author: kerrnel <kerrnel@chromium.org> Date: Fri Jan 27 05:22:26 2017 Add "Relaunch Chrome" dialog to Mac Views. This implements the Relaunch Chrome dialog as a Views based dialog on the mac platform. BUG= 684167 TEST=./out/Default/browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --dialog=UpdateRecommendedDialogTest.InvokeDialog_default Review-Url: https://codereview.chromium.org/2652823003 Cr-Commit-Position: refs/heads/master@{#446601} [modify] https://crrev.com/28a279f9a121b7948b388257a43c79823bf311d6/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/28a279f9a121b7948b388257a43c79823bf311d6/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/28a279f9a121b7948b388257a43c79823bf311d6/chrome/browser/ui/cocoa/browser_window_cocoa.mm [add] https://crrev.com/28a279f9a121b7948b388257a43c79823bf311d6/chrome/browser/ui/update_chrome_dialog_browsertest.cc [modify] https://crrev.com/28a279f9a121b7948b388257a43c79823bf311d6/chrome/browser/ui/views/browser_dialogs_views_mac.cc [modify] https://crrev.com/28a279f9a121b7948b388257a43c79823bf311d6/chrome/test/BUILD.gn
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0c12ecaa44ccc4511ea33c1705dec4caa972304 commit f0c12ecaa44ccc4511ea33c1705dec4caa972304 Author: tapted <tapted@chromium.org> Date: Tue Feb 07 00:04:50 2017 Run the "Relaunch Chrome" dialog test everywhere. For Linux, this requires an update to WidgetTest::GetAllWidgets() (added in r447216) in order to include Widgets created with a parent aura::Window that is a DesktopWindowTreeHost's root rather than the host's content window. BUG= 684167 , 683808 Review-Url: https://codereview.chromium.org/2663163004 Cr-Commit-Position: refs/heads/master@{#448452} [modify] https://crrev.com/f0c12ecaa44ccc4511ea33c1705dec4caa972304/chrome/browser/ui/update_chrome_dialog_browsertest.cc [modify] https://crrev.com/f0c12ecaa44ccc4511ea33c1705dec4caa972304/ui/views/test/widget_test_aura.cc [modify] https://crrev.com/f0c12ecaa44ccc4511ea33c1705dec4caa972304/ui/views/test/widget_test_unittest.cc
,
Feb 7 2017
,
May 12 2017
Trent, where do we stand on this?
,
May 15 2017
I can take it the next steps. This is probably a good candidate for going to UI review. Although on Mac it has questions around modality, and the "sheet" behaviour it uses..
,
Sep 5 2017
,
Sep 5 2017
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Jan 10 2018
Load balancing away from tapted@
,
Feb 12 2018
Here's how it looks when clamped to the 320 width.
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bbceb608ae1119cf341e208e1bfae4ecc33c3be commit 4bbceb608ae1119cf341e208e1bfae4ecc33c3be Author: Allen Bauer <kylixrd@chromium.org> Date: Tue Feb 13 22:16:08 2018 Updated Restart Chrome/Chromium dialog to Harmony spec width. Bug: 684167 Change-Id: Ibcaf1727289bf1321c33fdfb68d3321dc5205397 Reviewed-on: https://chromium-review.googlesource.com/914528 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#536506} [modify] https://crrev.com/4bbceb608ae1119cf341e208e1bfae4ecc33c3be/chrome/browser/ui/views/update_recommended_message_box.cc
,
Feb 14 2018
Tried testing the issue on Win-10 using chrome version #66.0.3347.0 by clicking the 3 dot menu at the topmost right corner and selected "about google chrome" from help menu. Observed that the chrome upgraded to latest chrome version and did not get the update Relaunch Chrome dialog. kylixrd@/tapted@ - Is there any way this can be verified on the latest canary #66.0.3347.0 manually and requesting for help in verification of this on canary. Thanks...!!
,
Feb 14 2018
#14: Use the --simulate-elevated-recovery flag to invoke the "must relaunch chrome" dialog.
,
Jul 25
This is as much work as we'll do for Harmony specifically. File a new bug for further improvements. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kerrnel@chromium.org
, Jan 24 201764.9 KB
64.9 KB View Download