New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684167 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Mac
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocked on:
issue 671820

Blocking:
issue 630357



Sign in to add a comment

Harmony - update Relaunch Chrome dialog

Project Member Reported by tapted@chromium.org, Jan 24 2017

Issue description

Chrome Version       : 57.0.2984.0

On Cocoa Mac, it looks like the attached; a window-modal sheet.

It's shown after selecting the 'Update Google Chrome' menu item from the Chrome App Menu.
 
Screen Shot 2017-01-24 at 11.13.14 am.png
61.3 KB View Download
Screen Shot 2017-01-24 at 11.10.16 AM.png
64.9 KB View Download
Summary: Harmony - update Relaunch Chrome dialog (was: Harmony: Relaunch Chrome Dialog)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0c12ecaa44ccc4511ea33c1705dec4caa972304

commit f0c12ecaa44ccc4511ea33c1705dec4caa972304
Author: tapted <tapted@chromium.org>
Date: Tue Feb 07 00:04:50 2017

Run the "Relaunch Chrome" dialog test everywhere.

For Linux, this requires an update to WidgetTest::GetAllWidgets() (added
in r447216) in order to include Widgets created with a parent
aura::Window that is a DesktopWindowTreeHost's root rather than the
host's content window.

BUG= 684167 ,  683808 

Review-Url: https://codereview.chromium.org/2663163004
Cr-Commit-Position: refs/heads/master@{#448452}

[modify] https://crrev.com/f0c12ecaa44ccc4511ea33c1705dec4caa972304/chrome/browser/ui/update_chrome_dialog_browsertest.cc
[modify] https://crrev.com/f0c12ecaa44ccc4511ea33c1705dec4caa972304/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/f0c12ecaa44ccc4511ea33c1705dec4caa972304/ui/views/test/widget_test_unittest.cc

Blockedon: 671820
next step before UI review is blocked on  Issue 671820 
Owner: tapted@chromium.org
Status: Assigned (was: Started)
Trent, where do we stand on this? 

Comment 7 by tapted@chromium.org, May 15 2017

I can take it the next steps. This is probably a good candidate for going to UI review. Although on Mac it has questions around modality, and the "sheet" behaviour it uses..
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
The NextAction date has arrived: 2017-11-10

Comment 11 by bsep@chromium.org, Jan 10 2018

Cc: tapted@chromium.org
Owner: bsep@chromium.org
Load balancing away from tapted@
Here's how it looks when clamped to the 320 width.
RelaunchChromeDialog.png
5.9 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bbceb608ae1119cf341e208e1bfae4ecc33c3be

commit 4bbceb608ae1119cf341e208e1bfae4ecc33c3be
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Feb 13 22:16:08 2018

Updated Restart Chrome/Chromium dialog to Harmony spec width.

Bug:  684167 
Change-Id: Ibcaf1727289bf1321c33fdfb68d3321dc5205397
Reviewed-on: https://chromium-review.googlesource.com/914528
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536506}
[modify] https://crrev.com/4bbceb608ae1119cf341e208e1bfae4ecc33c3be/chrome/browser/ui/views/update_recommended_message_box.cc

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tried testing the issue on Win-10 using chrome version #66.0.3347.0 by clicking the 3 dot menu at the topmost right corner and selected "about google chrome" from help menu. Observed that the chrome upgraded to latest chrome version and did not get the update Relaunch Chrome dialog.

kylixrd@/tapted@ - Is there any way this can be verified on the latest canary #66.0.3347.0 manually and requesting for help in verification of this on canary.

Thanks...!!

Comment 15 by bsep@chromium.org, Feb 14 2018

#14: Use the --simulate-elevated-recovery flag to invoke the "must relaunch chrome" dialog.
Status: Fixed (was: Assigned)
This is as much work as we'll do for Harmony specifically. File a new bug for further improvements.

Sign in to add a comment