New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684153 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

[MD setting] UI touch ups from Alan

Project Member Reported by dschuyler@chromium.org, Jan 23 2017

Issue description

In the doc at
https://docs.google.com/a/google.com/document/d/1wFAALiYaiQEMdV3rrJfdKAutq6xX8xlvFg1Dd7hHxl8/edit?usp=sharing
Alan details some UI fixes as Pri-2 importance. This bug covers the items in that Pri-2 list.

- google grey 900 for primary text
- enterprise icons, extension-enabled icons: change to 16x16
- add 4px between subpage arrow and subpage header (total padding amount = 20px)
- expand card and search box width from 640px to 680px (same internal padding)
- expand two-line rows from 60 to 64px (allows for 16px padding above and below text)
- ensure all text has a line height of 20px
- Rule-line color for dropdowns and text inputs should be the same
- Expected is the lighter dropdown version 
- add 100ms delay on hiding the sidenav, to allow for ripple, when clicking a section title.
- add tooltips for extension-control and policy indicators?

 
Blocking: -671375
Whoops, only the pri-1 list should be blocking 671375.

Comment 2 by dbeam@chromium.org, Jan 24 2017

Blocking: 671375
no, p2 should as well, they're just ... lower priority
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/876cafa176fb331cd498c895d6ccbb15f206eb04

commit 876cafa176fb331cd498c895d6ccbb15f206eb04
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 17 02:29:47 2017

MD Settings: Increase content width from 640px to 680px.

BUG= 684153 , 692916 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2697193005
Cr-Commit-Position: refs/heads/master@{#451190}

[modify] https://crrev.com/876cafa176fb331cd498c895d6ccbb15f206eb04/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/876cafa176fb331cd498c895d6ccbb15f206eb04/chrome/browser/resources/settings/settings_vars_css.html

Owner: dschuyler@chromium.org
Status: Assigned (was: Available)
- add 100ms delay on hiding the sidenav, to allow for ripple, when clicking a section title.

is moved to  Issue 703436 
Appears to be done (no repro on latest code):
- expand two-line rows from 60 to 64px (allows for 16px padding above and below text)


Moved to another bug:
- add 100ms delay on hiding the sidenav, to allow for ripple, when clicking a section title.
 Issue 703436 
- add tooltips for extension-control and policy indicators?
 Issue 704001 


Remaining:
- google grey 900 for primary text
- enterprise icons, extension-enabled icons: change to 16x16
- add 4px between subpage arrow and subpage header (total padding amount = 20px)
- expand card and search box width from 640px to 680px (same internal padding)
- ensure all text has a line height of 20px
- Rule-line color for dropdowns and text inputs should be the same
- Expected is the lighter dropdown version 

Comment 7 by dbeam@chromium.org, Mar 27 2017

hiding the side nav on ripple showing IS NOT a beta blocker (bettes@ agrees)
For 
- Rule-line color for dropdowns and text inputs should be the same
- Expected is the lighter dropdown version 

It looks like it may have been addressed already. Here's a shot of the two lines (the hex values match for the rendered values).
grey lines.png
196 bytes View Download
Summary update:

scottchen@ has been addressing these separately from this bug. After comparing our lists, it looks like this is the only outstanding item on this bug:

- enterprise icons, extension-enabled icons: change to 16x16
Status: Fixed (was: Assigned)
That last bit "enterprise icons, extension-enabled icons: change to 16x16" was moved to  Issue 706605 .

Sign in to add a comment