New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684152 link

Starred by 3 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
dbeam@chromium.org
█ scottchen@chromium.org
tbuck...@chromium.org
bettes@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

[MD setting] critical UI touch ups from Alan

Project Member Reported by dschuyler@chromium.org, Jan 23 2017 
In the doc at
https://docs.google.com/a/google.com/document/d/1wFAALiYaiQEMdV3rrJfdKAutq6xX8xlvFg1Dd7hHxl8/edit?usp=sharing
Alan details some UI fixes as Pri-1 importance. This bug covers the items in that Pri-1 list.

- keyboard navigating: ripples on switches should be 40px and centered
- dialogues: there’s no drop shadow 
	shadow 1: 0px 0px 16px #000 0.12a 
shadow 2: 0px 16px 16px #000 0.24a
- subpages: ensure there’s a 24px bottom-padding in header row (settings-box first) screenshot
- all MD button corner radii seem to be 1.5px and not 2px screenshot
- component switch_off: right hand side is clipped

Comment 1 by scottchen@chromium.org, Jan 24 2017

Owner: scottchen@chromium.org
Status: Started (was: Available)

Comment 2 by tbuckley@google.com, Jan 25 2017

Labels: Hotlist-MD-Settings-General

Comment 3 by bettes@chromium.org, Jan 25 2017 

New tracker sheet can be found here: 
https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4dbKrx4/edit#gid=0


LMK if you have any questions!

Comment 4 by scottchen@chromium.org, Jan 25 2017 

I'm gonna start knocking them out. I'll change the ones I am working on to "In-Progress" and once they land, I'll change them to "Complete".

Comment 5 by scottchen@chromium.org, Jan 25 2017 

Toggle ripple fixes are blocked on merge for: https://github.com/PolymerElements/paper-toggle-button/pull/113
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fafa62de998f555b86b12040d2c776297aa38567

commit fafa62de998f555b86b12040d2c776297aa38567
Author: scottchen <scottchen@chromium.org>
Date: Sat Jan 28 00:45:39 2017

MD Settings: fix settings-toggle-button label text overflow.

This is to fix appearance page's "[Show home button] long URLs breaks page" bug.
Once this lands, consumers of settings-toggle-button will be able to specify label-class and sub-label-class to be passed in and applied to the label elements.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2661533002
Cr-Commit-Position: refs/heads/master@{#446856}

[modify] https://crrev.com/fafa62de998f555b86b12040d2c776297aa38567/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/fafa62de998f555b86b12040d2c776297aa38567/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/fafa62de998f555b86b12040d2c776297aa38567/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/fafa62de998f555b86b12040d2c776297aa38567/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/fafa62de998f555b86b12040d2c776297aa38567/chrome/browser/resources/settings/settings_vars_css.html
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2176d0c08e0a2367c91c2edb8ae255f185130ae

commit a2176d0c08e0a2367c91c2edb8ae255f185130ae
Author: scottchen <scottchen@chromium.org>
Date: Tue Jan 31 20:09:59 2017

MD Settings: Fix several global UI polish bugs.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2656563006
Cr-Commit-Position: refs/heads/master@{#447310}

[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/a2176d0c08e0a2367c91c2edb8ae255f185130ae/ui/webui/resources/css/text_defaults_md.css
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8126246d566c209b04c3beb9a88b9258d37461c

commit d8126246d566c209b04c3beb9a88b9258d37461c
Author: scottchen <scottchen@chromium.org>
Date: Fri Feb 03 04:08:37 2017

MD Settings: Fix styles in several places.

- Some buttons were missing the "secondary-button"/"cancel-button" class.
- removing rule-lines
- remove unnecessary controls

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668163002
Cr-Commit-Position: refs/heads/master@{#447923}

[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/browser/resources/settings/site_settings/media_picker.html
[modify] https://crrev.com/d8126246d566c209b04c3beb9a88b9258d37461c/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Comment 12 by dbeam@chromium.org, Feb 6 2017 

bettes@: why do we want a open-in-new for changing the download directory?

Comment 14 by tbuck...@chromium.org, Feb 7 2017

Cc: dschuyler@chromium.org
 Issue 681203  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a66377cd8c7d4ff11cc22ef6bbec2b967e20bdb

commit 4a66377cd8c7d4ff11cc22ef6bbec2b967e20bdb
Author: scottchen <scottchen@chromium.org>
Date: Wed Feb 08 00:10:26 2017

MD Settings: update reset dialog visuals

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2684703005
Cr-Commit-Position: refs/heads/master@{#448809}

[modify] https://crrev.com/4a66377cd8c7d4ff11cc22ef6bbec2b967e20bdb/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4a66377cd8c7d4ff11cc22ef6bbec2b967e20bdb/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b76312adeb89b0457222c39ab3e38130b88506

commit 79b76312adeb89b0457222c39ab3e38130b88506
Author: scottchen <scottchen@chromium.org>
Date: Wed Feb 08 00:13:16 2017

MD Settings: Privacy section visual touch-ups

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2678763003
Cr-Commit-Position: refs/heads/master@{#448811}

[modify] https://crrev.com/79b76312adeb89b0457222c39ab3e38130b88506/chrome/browser/resources/settings/site_settings/zoom_levels.html
[modify] https://crrev.com/79b76312adeb89b0457222c39ab3e38130b88506/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc09866f18c741c81b93c9314829a3046c724128

commit fc09866f18c741c81b93c9314829a3046c724128
Author: scottchen <scottchen@chromium.org>
Date: Wed Feb 08 02:08:28 2017

MD Settings: Adjust icon ripples and row sizing.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675183005
Cr-Commit-Position: refs/heads/master@{#448854}

[modify] https://crrev.com/fc09866f18c741c81b93c9314829a3046c724128/chrome/browser/resources/settings/settings_vars_css.html

Comment 19 by dbeam@chromium.org, Feb 8 2017

Blockedon: 680406
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a043d16382a6c55eb303da006c7378231901b704

commit a043d16382a6c55eb303da006c7378231901b704
Author: scottchen <scottchen@chromium.org>
Date: Wed Feb 08 22:23:22 2017

MD Settings: Make subpage extend to bottom of page with no overscroll

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682853002
Cr-Commit-Position: refs/heads/master@{#449107}

[modify] https://crrev.com/a043d16382a6c55eb303da006c7378231901b704/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/a043d16382a6c55eb303da006c7378231901b704/chrome/browser/resources/settings/settings_page_css.html

Comment 21 by dbeam@chromium.org, Feb 8 2017

Blockedon: -680406
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a29a636fccf8d7e1f09d6ee445666622561ed0

commit 64a29a636fccf8d7e1f09d6ee445666622561ed0
Author: scottchen <scottchen@chromium.org>
Date: Wed Feb 08 23:56:51 2017

MD Settings: move all the (?) from sub-subpage to subpage in content settings

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2685813002
Cr-Commit-Position: refs/heads/master@{#449147}

[modify] https://crrev.com/64a29a636fccf8d7e1f09d6ee445666622561ed0/chrome/browser/resources/settings/privacy_page/privacy_page.html
Project Member

Comment 23 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/355642b72b189fcc865eeca8d0fcbef8ac91e6e7

commit 355642b72b189fcc865eeca8d0fcbef8ac91e6e7
Author: scottchen <scottchen@chromium.org>
Date: Mon Feb 13 21:35:05 2017

MD Settings: Convert spell-check from checkbox to toggle.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2683583008
Cr-Commit-Position: refs/heads/master@{#450099}

[modify] https://crrev.com/355642b72b189fcc865eeca8d0fcbef8ac91e6e7/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/355642b72b189fcc865eeca8d0fcbef8ac91e6e7/chrome/browser/resources/settings/languages_page/languages_page.js
Project Member

Comment 24 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cc82777e38c6e39cfcbbdfccce6216a222251e1

commit 8cc82777e38c6e39cfcbbdfccce6216a222251e1
Author: scottchen <scottchen@chromium.org>
Date: Mon Feb 13 22:35:41 2017

MD Settings: in autofill section, change google-payment related entries to outlinks instead.

If an entry in the address or credit card autofill settings is connected to Google Payment, this CL makes it use a outlink-icon button that directly links to the google payment page, as opposed to using a dropdown that conditionally decides what to do based on the entry type.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2681143004
Cr-Commit-Position: refs/heads/master@{#450123}

[modify] https://crrev.com/8cc82777e38c6e39cfcbbdfccce6216a222251e1/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/8cc82777e38c6e39cfcbbdfccce6216a222251e1/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/8cc82777e38c6e39cfcbbdfccce6216a222251e1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/8cc82777e38c6e39cfcbbdfccce6216a222251e1/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Comment 25 by tbuck...@chromium.org, Feb 22 2017

Status: Fixed (was: Started)
Marking as fixed based on conversation in Settings UX sync.
Project Member

Comment 26 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3f17d64c61c095f5d7542bb74e2e7137f339b14

commit f3f17d64c61c095f5d7542bb74e2e7137f339b14
Author: scottchen <scottchen@chromium.org>
Date: Thu Feb 23 20:13:35 2017

MD Settings: adjust focus-outline behaviors on search engine iron-list.

Goal:
Based on offline discussion with dbeam@, the result should be:
  - mouse clicking anywhere should behave as user were clicking on dead-space.
  - pressing tab after clicking on an item would go into it's child icon-button
    (because on web pages when you click somewhere and clicks tab it would go
    to the "next" focusable thing, next as in right-and-down in pixels)
  - clicking on an item would not show focus-line, but when you press up and
    down it'll then show the focus-line on the new items you're focusing.
  - clicking on a row thats focused by keyboard should not unfocus the row.

Caveat #1:
  We can't simply just add .no-outline to everything the mouse clicks - in case
  the user clicks on something that was focused by keyboard, the click would
  appear to unexpectedly unfocus the item.

Caveat #2:
  We can't just do "document.activeElement == this" (as we did for
  action-links), because document.activeElement only track interactive elements
  (inputs, buttons etc.) and not divs etc.

Explaining the solution in the CL:
  When user uses keyboard to traverse through the iron-list, key-down is fired
  on the previously focused item, then key-up is fired on the newly focused
  item. We use this behavior here to determine if an item is already in focus
  via keyboard. If it were, we don't add .no-outline.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2700863002
Cr-Commit-Position: refs/heads/master@{#452601}

[modify] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/compiled_resources2.gyp
[add] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/focusable_iron_list_item_behavior.html
[add] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/focusable_iron_list_item_behavior.js
[modify] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp
[modify] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/f3f17d64c61c095f5d7542bb74e2e7137f339b14/chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js
Project Member

Comment 27 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b33480b93950a0153c179f5336aeaf382ff8d5

commit 08b33480b93950a0153c179f5336aeaf382ff8d5
Author: scottchen <scottchen@chromium.org>
Date: Thu Feb 23 21:19:37 2017

MD Settings: add empty list message for spell-check edit page.

Also move the word list to a template dom-if, and fix auto-scroll when new words are added.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2690263002
Cr-Commit-Position: refs/heads/master@{#452633}

[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/app/settings_strings.grdp
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/test/data/webui/settings/edit_dictionary_page_test.js
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/test/data/webui/settings/fake_language_settings_private.js
[modify] https://crrev.com/08b33480b93950a0153c179f5336aeaf382ff8d5/chrome/test/data/webui/settings/languages_page_browsertest.js
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27793e2b00cd4f06e24cde9599be5693006ed02b

commit 27793e2b00cd4f06e24cde9599be5693006ed02b
Author: scottchen <scottchen@chromium.org>
Date: Thu Mar 30 23:53:49 2017

MD Settings: long dialog body should have overscroll line.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2702523005
Cr-Commit-Position: refs/heads/master@{#460937}

[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/27793e2b00cd4f06e24cde9599be5693006ed02b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/808ae591999af99f6ada8ceeb73c28e6d27a55f8

commit 808ae591999af99f6ada8ceeb73c28e6d27a55f8
Author: stgao <stgao@chromium.org>
Date: Fri Mar 31 01:05:20 2017

Revert of MD Settings: long dialog body should have overscroll line. (patchset #9 id:180001 of https://codereview.chromium.org/2702523005/ )

Reason for revert:
Failed
CrElementsDialogTest.All on Waterfall

https://findit-for-me.appspot.com/waterfall/failure?url=https%3A%2F%2Fbuild.chromium.org%2Fp%2Fchromium.linux%2Fbuilders%2FLinux%2520Tests%2Fbuilds%2F54060

Original issue's description:
> MD Settings: long dialog body should have overscroll line.
>
> BUG= 684152 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2702523005
> Cr-Commit-Position: refs/heads/master@{#460937}
> Committed: https://chromium.googlesource.com/chromium/src/+/27793e2b00cd4f06e24cde9599be5693006ed02b

TBR=dpapad@chromium.org,stevenjb@chromium.org,scottchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 684152 

Review-Url: https://codereview.chromium.org/2781363004
Cr-Commit-Position: refs/heads/master@{#460967}

[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/808ae591999af99f6ada8ceeb73c28e6d27a55f8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34

commit a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34
Author: scottchen <scottchen@chromium.org>
Date: Fri Mar 31 23:06:31 2017

MD Settings: long dialog body should have overscroll line.

BUG= 684152 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2702523005
Cr-Original-Commit-Position: refs/heads/master@{#460937}
Committed: https://chromium.googlesource.com/chromium/src/+/27793e2b00cd4f06e24cde9599be5693006ed02b
Review-Url: https://codereview.chromium.org/2702523005
Cr-Commit-Position: refs/heads/master@{#461264}

[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/a4c0720e53ea714a31f27ee2a8c4bf6ec2841a34/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
►

Sign in to add a comment