New issue
Advanced search Search tips

Issue 684147 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove PrioritizeArcInstance D-Bus interface

Project Member Reported by yusukes@chromium.org, Jan 23 2017

Issue description

Remove PrioritizeArcInstance D-Bus interface from session_manager and Chromium. It's deprecated and Chromium r445536+ no longer uses the interface.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bbbf2012bb7bfb160686f119bd51b6baff648513

commit bbbf2012bb7bfb160686f119bd51b6baff648513
Author: yusukes <yusukes@google.com>
Date: Tue Jan 24 05:26:44 2017

login: Remove PrioritizeArcInstance()

The D-Bus interface is deprecated and Chromium >=58.0.2993.0
does not call it.

BUG= chromium:684147 
TEST=git grep PrioritizeArcInstance
CQ-DEPEND=CL:431823

Change-Id: I4b80f48a96fd24bc4407bd62bd86cad89033defc
Reviewed-on: https://chromium-review.googlesource.com/431996
Commit-Ready: Yusuke Sato <yusukes@chromium.org>
Tested-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/bbbf2012bb7bfb160686f119bd51b6baff648513/login_manager/dbus_bindings/org.chromium.SessionManagerInterface.xml
[modify] https://crrev.com/bbbf2012bb7bfb160686f119bd51b6baff648513/login_manager/session_manager_dbus_adaptor.cc
[modify] https://crrev.com/bbbf2012bb7bfb160686f119bd51b6baff648513/login_manager/session_manager_dbus_adaptor.h
[modify] https://crrev.com/bbbf2012bb7bfb160686f119bd51b6baff648513/login_manager/SessionManager.conf

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/9c74156d9ec2f4032acf0e193ac09c47b540df48

commit 9c74156d9ec2f4032acf0e193ac09c47b540df48
Author: yusukes <yusukes@google.com>
Date: Tue Jan 24 05:23:36 2017

dbus: login_manager: Remove PrioritizeArcInstance

The interface is deprecated and is no longer used.

BUG= chromium:684147 
TEST=None

Change-Id: Ia6a884368cfbfe1ad6dbc83c14a498dcc6503937
Reviewed-on: https://chromium-review.googlesource.com/431823
Commit-Ready: Yusuke Sato <yusukes@chromium.org>
Tested-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/9c74156d9ec2f4032acf0e193ac09c47b540df48/dbus/login_manager/dbus-constants.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dcd14d399469bd6c579f1ddb16380aed836a80e

commit 8dcd14d399469bd6c579f1ddb16380aed836a80e
Author: yusukes <yusukes@chromium.org>
Date: Mon Jan 30 20:36:12 2017

Roll src/third_party/cros_system_api/ 83f09286..9c74156d (1 commit).

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/83f09286..9c74156d

$ git log 83f09286..9c74156d --date=short --no-merges --format='%ad %ae %s'
2017-01-23 yusukes@google.com dbus: login_manager: Remove PrioritizeArcInstance

BUG= 684147 
TEST=gclient sync, try

Review-Url: https://codereview.chromium.org/2667613003
Cr-Commit-Position: refs/heads/master@{#447053}

[modify] https://crrev.com/8dcd14d399469bd6c579f1ddb16380aed836a80e/DEPS

Status: Fixed (was: Started)
Done

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment