New issue
Advanced search Search tips

Issue 684139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Update parameter isOn in CollectionViewSwitchCell() to be more clear

Project Member Reported by baxley@chromium.org, Jan 23 2017

Issue description

From callsites it's not clear what isOn means.
 

Comment 1 by baxley@chromium.org, Nov 18 2017

Components: -Test>iOS Tests
Owner: ----
Status: Available (was: Assigned)
Labels: M-65
Owner: mahmadi@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9992fdc60e6ddd5e99e4bacde183fea582e3a653

commit 9992fdc60e6ddd5e99e4bacde183fea582e3a653
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Jan 23 21:34:02 2018

[AF] Disables save passwords switch item in SavePasswordsCVC in edit mode

Bug: 799031,  684139 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3dbb7c648c4ac1ceebba4e6ff819a032287cddbc
Reviewed-on: https://chromium-review.googlesource.com/876999
Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531357}
[modify] https://crrev.com/9992fdc60e6ddd5e99e4bacde183fea582e3a653/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/9992fdc60e6ddd5e99e4bacde183fea582e3a653/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/9992fdc60e6ddd5e99e4bacde183fea582e3a653/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/9992fdc60e6ddd5e99e4bacde183fea582e3a653/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/9992fdc60e6ddd5e99e4bacde183fea582e3a653/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/9992fdc60e6ddd5e99e4bacde183fea582e3a653/ios/chrome/test/earl_grey/chrome_matchers.mm

Status: Fixed (was: Started)

Sign in to add a comment