New issue
Advanced search Search tips

Issue 684137 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NQE should use the cached effective connection type to estimate throughput

Project Member Reported by tbansal@chromium.org, Jan 23 2017 
NQE should use the cached effective connection type to estimate throughput. 

Currently, throughput is not computed from the cached effective connection type. Computing the effective connection type currently requires knowledge of both the RTT and the throughput. 

Since throughput is not computed from the cached ECT, this means that currently NQE is unable to determine the ECT even after reading the cached prefs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ab374ddc2e729b0b914e8774b11233438e29ea

commit 22ab374ddc2e729b0b914e8774b11233438e29ea
Author: tbansal <tbansal@chromium.org>
Date: Fri Jan 27 18:49:21 2017

Add effective connection type to throughput mapping

Add effective connection type to throughput mapping for Network Quality
Estimator (NQE).

BUG= 684137 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648353003
Cr-Commit-Position: refs/heads/master@{#446723}

[modify] https://crrev.com/22ab374ddc2e729b0b914e8774b11233438e29ea/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/22ab374ddc2e729b0b914e8774b11233438e29ea/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/22ab374ddc2e729b0b914e8774b11233438e29ea/net/nqe/network_quality_estimator_unittest.cc

Comment 2 by tbansal@chromium.org, Jan 30 2017

Labels: Merge-Request-58

Comment 3 by tbansal@chromium.org, Jan 30 2017

Labels: -Merge-Request-58 Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da99d8ede692fc2f39501f39d464cba3b9fa5bf0

commit da99d8ede692fc2f39501f39d464cba3b9fa5bf0
Author: Tarun Bansal <tbansal@google.com>
Date: Mon Jan 30 22:02:37 2017

Add effective connection type to throughput mapping

Add effective connection type to throughput mapping for Network Quality
Estimator (NQE).

BUG= 684137 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648353003
Cr-Commit-Position: refs/heads/master@{#446723}
(cherry picked from commit 22ab374ddc2e729b0b914e8774b11233438e29ea)

Review-Url: https://codereview.chromium.org/2663963002 .
Cr-Commit-Position: refs/branch-heads/2987@{#193}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/da99d8ede692fc2f39501f39d464cba3b9fa5bf0/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/da99d8ede692fc2f39501f39d464cba3b9fa5bf0/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/da99d8ede692fc2f39501f39d464cba3b9fa5bf0/net/nqe/network_quality_estimator_unittest.cc

Comment 6 by tbansal@chromium.org, Jan 30 2017

Labels: M-57
Status: Fixed (was: Started)

Comment 7 by tbansal@chromium.org, Feb 13 2017

Components: Internals>Network>NetworkQuality

Comment 8 by tbansal@chromium.org, Feb 14 2017

Labels: -nqe
►

Sign in to add a comment