New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684120 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

MD Settings: Content Settings > Flash page has two "ask first" toggle with different values

Project Member Reported by scottchen@chromium.org, Jan 23 2017

Issue description

Chrome Version: 58.0.2991.0
OS: Spotted on Mac & ChromeOS, most likely all.

What steps will reproduce the problem?
(1) Go to Content Settings > Flash
(2) Observe first two toggles have duplicate text

What is the expected result?
There should only be one "Ask First" toggle

What happens instead?
- There's two toggle with the same description
- Somehow the two duplicated toggles have different values.

 
Screen Shot 2017-01-23 at 2.58.23 PM.png
18.5 KB View Download
Description: Show this description
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by tbuckley@google.com, Jan 25 2017

Blocking: 671375
Labels: Hotlist-MD-Settings-Privacy-SiteSettings
I'm not seeing this on version 58.0.2992.0 on Linux.
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c9557cefe7c58e1fc6f887621ce9d5d7e269c1

commit 84c9557cefe7c58e1fc6f887621ce9d5d7e269c1
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jan 26 19:27:20 2017

[MD settings] correct label for policy controlled flash settings

This CL moves the category-default-setting away from using the
computeCategoryDesc() function to determine toggle labels. This fixes
an issue where the flash toggle was showing the incorrect label.

BUG= 684120 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2655463010
Cr-Commit-Position: refs/heads/master@{#446389}

[modify] https://crrev.com/84c9557cefe7c58e1fc6f887621ce9d5d7e269c1/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/84c9557cefe7c58e1fc6f887621ce9d5d7e269c1/chrome/browser/resources/settings/site_settings/category_default_setting.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 9426.0.0 / 59.0.3055.0

Sign in to add a comment