New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684116 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] Move message queue logic from PresentationDispatcher to PresentationConnectionProxy

Project Member Reported by zhaobin@chromium.org, Jan 23 2017 
https://codereview.chromium.org/2471573005/ introduces PresentationConnectionProxy for message exchange between controlling frame and receiver frame.

It would be great if we move message queue related logic from PresentationDispatcher to PresentationConnectionProxy, and make all message related logic reside in PresentationConnectionProxy class.

Comment 1 by sko...@chromium.org, Jan 26 2017

Status: Available (was: Untriaged)

Comment 2 by imch...@chromium.org, Jul 7 2017

Labels: Hotlist-Fixit-PE2017
Owner: imch...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75

commit 2fd16c44c565003cfb11e2fbc1c738b8f8e94d75
Author: Derek Cheng <imcheng@chromium.org>
Date: Thu Jul 13 23:17:18 2017

[PresentationAPI] Remove message handling logic from PresentationDispatcher.

- Remove message queue / message handling logic from PresentationDispatcher.
- Move Send{Text,Binary}Message methods from WebPresentationClient to
WebPresentationConnectionProxy.
- Remove unused DidReceive*Message methods from WebPresentationController.

Note that there is behavior change; previously the sending of a message is
blocked on the other side having processed the previous message
successfully. This pattern was previously used for control flow purposes
and is no longer deemed useful.

Bug:  684116 
Change-Id: I3589c4c047e7b5c16ff1a92a0d5e72bbf932023f
Reviewed-on: https://chromium-review.googlesource.com/563766
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486523}
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/content/renderer/presentation/presentation_connection_proxy.cc
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/content/renderer/presentation/presentation_connection_proxy.h
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/content/renderer/presentation/presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/content/renderer/presentation/presentation_dispatcher.h
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/third_party/WebKit/Source/modules/presentation/PresentationController.h
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionProxy.h
[modify] https://crrev.com/2fd16c44c565003cfb11e2fbc1c738b8f8e94d75/third_party/WebKit/public/platform/modules/presentation/WebPresentationController.h

Comment 4 by imch...@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment