New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684115 link

Starred by 1 user
Status: Fixed
Owner:
varkha@chromium.org
Closed: Feb 2017
Cc:
moh...@chromium.org
sadrul@chromium.org
█ bruthig@chromium.org
█ reve...@chromium.org
█ tdander...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Want a metric for how smooth the animations are

Project Member Reported by varkha@chromium.org, Jan 23 2017 
It would be nice to be able to add metrics for actual compositor frame rate during particular animations or animation sequences.

First candidates:
- Entering and exiting Chrome OS overview mode.
- Ink drop ripples from Material Design work.

It would also be great to add perf tests for some of the scenarios.

Comment 2 by tdander...@chromium.org, Jan 24 2017

Labels: Proj-MaterialDesign-CrOS
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62ba671daf03f09c08257fab4559a31259aa09ce

commit 62ba671daf03f09c08257fab4559a31259aa09ce
Author: varkha <varkha@chromium.org>
Date: Wed Jan 25 19:09:46 2017

[animations] Adds metrics for jank on selected layer animations

This CL is WIP to add UMA metrics for "smoothness" factor on
selected layer animations. The UI developer would be able to
tag selected animations (sequences or elements) with a "name"
and then have UMA data available for how smooth (how close to
ideal 60 fps) the animation is in the field.

BUG= 684115 

Review-Url: https://codereview.chromium.org/2631333002
Cr-Commit-Position: refs/heads/master@{#446075}

[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/compositor.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/compositor.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animation_delegate.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animation_element.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animation_element.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animation_sequence.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animation_sequence.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animator.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_animator.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/scoped_layer_animation_settings.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/scoped_layer_animation_settings.h
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/test/test_layer_animation_delegate.cc
[modify] https://crrev.com/62ba671daf03f09c08257fab4559a31259aa09ce/ui/compositor/test/test_layer_animation_delegate.h

Comment 4 by tdander...@chromium.org, Jan 28 2017 

Valery, are you planning to merge anything back to m-57 here or should this be re-targeted to m-58?

Comment 5 by tdander...@chromium.org, Feb 8 2017

Labels: -M-57 M-58
Status: Fixed (was: Started)
►

Sign in to add a comment