[Presentation API] Combine ExistingPresentationConnectionCallbacks with PresentationConnectionCallbacks |
|||||
Issue descriptionhttps://codereview.chromium.org/2471263003/ adds m_connection field to PresentationConnectionCallbacks class. We can now combine ExistingPresentationConnectionCallbacks with PresentationConnectionCallbacks. 1. Add a new ctor to PresentationConnectionCallbacks: PresentationConnectionCallbacks(ScriptPromiseResolver*, PresentationConnection*); 2. In onSuccess(), create new m_connection object if m_connection is null. 3. remove ExistingPresentationConnectionCallbacks.*
,
May 10 2017
,
May 10 2017
,
Jul 19 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/527a2237f1ce8e61a31307b3d9c7f87154fc91fc commit 527a2237f1ce8e61a31307b3d9c7f87154fc91fc Author: Bin Zhao <zhaobin@chromium.org> Date: Fri Jul 21 00:42:58 2017 [Presentation API] Remove ExistingPresentationConnectionCallbacks - Added PresentationConnectionCallbacks::PresentationConnectionCallbacks(ScriptPromiseResolver*, PresentationConnection*); - In PresentationConnectionCallbacks::onSuccess(), create new m_connection object if m_connection is null. - Remove ExistingPresentationConnectionCallbacks.* files Bug: 684111 Change-Id: Ieaf696cce484d609659062f0b451c8e9510eda0a Reviewed-on: https://chromium-review.googlesource.com/578689 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488519} [modify] https://crrev.com/527a2237f1ce8e61a31307b3d9c7f87154fc91fc/third_party/WebKit/Source/modules/presentation/BUILD.gn [delete] https://crrev.com/4c629ccf4cf992ca5fafa271ed32127fcb8c0856/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.cpp [delete] https://crrev.com/4c629ccf4cf992ca5fafa271ed32127fcb8c0856/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h [modify] https://crrev.com/527a2237f1ce8e61a31307b3d9c7f87154fc91fc/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp [modify] https://crrev.com/527a2237f1ce8e61a31307b3d9c7f87154fc91fc/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h [modify] https://crrev.com/527a2237f1ce8e61a31307b3d9c7f87154fc91fc/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
,
Jul 21 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sko...@chromium.org
, Jan 26 2017