New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684104 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Investigate removing EarlGrey helpers that do assertions

Project Member Reported by baxley@chromium.org, Jan 23 2017

Issue description

Test code should be a bit more explicit than "normal" code, to make tests more clear to debug.

In some cases methods were over abstracted. We should review cases where a helper is prefixed by Assert and determine if the implementation should move inline.
 
Status: WontFix (was: Assigned)
The determination is that EarlGrey helpers can assert if it includes EarlGrey code. If it's a helper that is separate from  EarlGrey, then it should return something that the caller can decide how to handle (wait, assert, ignore, ...)

Sign in to add a comment