New issue
Advanced search Search tips

Issue 684100 link

Starred by 1 user
Status: Fixed
Owner:
qin...@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Failure in DownloadNotificationServiceTest.testResumeAllPendingDownloads

Project Member Reported by mariakho...@chromium.org, Jan 23 2017 
Failing on Lollipop Tablet Tester:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/6570

Exception from logcat:

78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: FATAL EXCEPTION: main
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: Process: org.chromium.chrome, PID: 27009
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.chromium.chrome.browser.download.DownloadInfo.getFileName()' on a null object reference
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at org.chromium.chrome.browser.download.DownloadManagerService$ClearPendingOMADownloadTask.onPostExecute(DownloadManagerService.java:436)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at org.chromium.chrome.browser.download.DownloadManagerService$ClearPendingOMADownloadTask.onPostExecute(DownloadManagerService.java:368)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at android.os.AsyncTask.finish(AsyncTask.java:636)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at android.os.AsyncTask.access$500(AsyncTask.java:177)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:653)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:135)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:5254)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Method.java:372)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
78485:  01-23 20:32:56.483 27009 27009 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
78485:  01-23 20:32:56.485   621 11382 W ActivityManager: Error in app org.chromium.chrome running instrumentation ComponentInfo{org.chromium.chrome.tests/org.chromium.chrome.test.ChromeInstrumentationTestRunner}:
78485:  01-23 20:32:56.485   621 11382 W ActivityManager:   java.lang.NullPointerException
78485:  01-23 20:32:56.485   621 11382 W ActivityManager:   java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.chromium.chrome.browser.download.DownloadInfo.getFileName()' on a null object reference
78485:  01-23 20:32:56.486 26974 26974 D AndroidRuntime: Shutting down VM
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3482758e2164874b6d52e320e354da289b1c2c47

commit 3482758e2164874b6d52e320e354da289b1c2c47
Author: qinmin <qinmin@chromium.org>
Date: Mon Jan 23 23:36:07 2017

Fix a crash caused by missing download ID from system DownloadManager for OMA downloads

When chrome crashes while OMA download is in progress, chrome will clear the download infomation when it restarts.
However, it is possible that the system download Id no longer exists in DownloadManager.
This will cause Chrome to crash on the first start up.
This CL catches the problem so we don't crash in this rare cases.

BUG= 684100 

Review-Url: https://codereview.chromium.org/2652863002
Cr-Commit-Position: refs/heads/master@{#445544}

[modify] https://crrev.com/3482758e2164874b6d52e320e354da289b1c2c47/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 2 by qin...@chromium.org, Jan 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment