Remove C-style helpers that wrap EarlGrey calls |
|||||||
Issue description
We have some examples where there is a C-style method wrapping an EarlGrey objective-C call.
For example in qr_scanner_view_controller_egtest.mm, there is TapButton().
Instead the test should call:
[[EarlGrey selectElementWithMatcher:grey_matchFoo()]
performAction:grey_tap()];
If that code gets too long, it is possible to create (or use existing matchers).
,
Mar 6 2017
,
Mar 6 2017
,
Apr 14 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d commit dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d Author: baxley <baxley@chromium.org> Date: Tue Apr 18 18:57:21 2017 Delete TapButtonWithLabelId from first_run_egtest.mm. EarlGrey tests should perform taps in EarlGrey style, rather than creating static C-methods to combine actions. Custom matchers are used to make the code more readable. BUG=684099 Review-Url: https://codereview.chromium.org/2823913002 Cr-Commit-Position: refs/heads/master@{#465311} [modify] https://crrev.com/dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d/ios/chrome/browser/ui/first_run/first_run_egtest.mm [modify] https://crrev.com/dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/dfc326b3c2dc9801898bba2d0f1cd2de52f83c9d/ios/chrome/test/earl_grey/chrome_matchers.mm
,
Nov 21 2017
Not sure if this is worth the churn. It's quite a bit of work to fix some of our tests (e.g. QR). Most of our other tests have been fixed.
,
Nov 22
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 29
Not sure who the right person to handle EG infra issues; cc'ing some test people. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by baxley@chromium.org
, Jan 23 2017