New issue
Advanced search Search tips

Issue 684098 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Move webWillFinishHistoryNavigationFromEntry: out of if-else conditions

Project Member Reported by eugene...@chromium.org, Jan 23 2017

Issue description

This will be unnecessary once webWillFinishHistoryNavigationFromEntry: is removed from CRWWebDelegate
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b2fb40242a52cf1cf25b14eff6f095432c7bb81

commit 9b2fb40242a52cf1cf25b14eff6f095432c7bb81
Author: eugenebut <eugenebut@chromium.org>
Date: Wed Mar 01 22:53:02 2017

Cleaned up code duplication in -[CRWWebController goToItemAtIndex:].

Moved updateDesktopUserAgentForEntry:fromEntry: out of conditional
blocks, because the calls order does not matter as long as |toEntry| is
correct.

Removed unnecessary webWillFinishHistoryNavigationFromEntry: call. For
same-document navigations Tab gets webState:didFinishNavigation: call
and for different-document navigations Tab gets
webState:didStartProvisionalNavigationForURL:. Both calls update the
toolbar, which is the only thing done in
webWillFinishHistoryNavigationFromEntry:.

BUG= 684098 

Review-Url: https://codereview.chromium.org/2728723002
Cr-Commit-Position: refs/heads/master@{#454079}

[modify] https://crrev.com/9b2fb40242a52cf1cf25b14eff6f095432c7bb81/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment