Move webWillFinishHistoryNavigationFromEntry: out of if-else conditions |
||
Issue descriptionThis will be unnecessary once webWillFinishHistoryNavigationFromEntry: is removed from CRWWebDelegate
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b2fb40242a52cf1cf25b14eff6f095432c7bb81 commit 9b2fb40242a52cf1cf25b14eff6f095432c7bb81 Author: eugenebut <eugenebut@chromium.org> Date: Wed Mar 01 22:53:02 2017 Cleaned up code duplication in -[CRWWebController goToItemAtIndex:]. Moved updateDesktopUserAgentForEntry:fromEntry: out of conditional blocks, because the calls order does not matter as long as |toEntry| is correct. Removed unnecessary webWillFinishHistoryNavigationFromEntry: call. For same-document navigations Tab gets webState:didFinishNavigation: call and for different-document navigations Tab gets webState:didStartProvisionalNavigationForURL:. Both calls update the toolbar, which is the only thing done in webWillFinishHistoryNavigationFromEntry:. BUG= 684098 Review-Url: https://codereview.chromium.org/2728723002 Cr-Commit-Position: refs/heads/master@{#454079} [modify] https://crrev.com/9b2fb40242a52cf1cf25b14eff6f095432c7bb81/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 1 2017
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725f29f1dd104cbc643cd14af8eebf768520b27c commit 725f29f1dd104cbc643cd14af8eebf768520b27c Author: kkhorimoto <kkhorimoto@chromium.org> Date: Thu Mar 09 00:38:53 2017 Removed CRWSessionEntry from CRWWebController. BUG=454984, 684098 Review-Url: https://codereview.chromium.org/2705673003 Cr-Commit-Position: refs/heads/master@{#455615} [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/web/navigation/session_storage_builder.mm [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/web/public/web_state/ui/crw_web_delegate.h [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/web/web_state/ui/crw_web_controller_unittest.mm [modify] https://crrev.com/725f29f1dd104cbc643cd14af8eebf768520b27c/ios/web/web_state/web_state_impl.mm |
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Mar 1 2017