New filesystem notification should open Files app when clicked |
|||
Issue descriptionGoogle Chrome 56.0.2924.67 (Official Build) beta (32-bit) Platform 9000.66.0 (Official Build) beta-channel kevin When I insert a USB drive, I get a "Removable device detected" notification. Clicking in the main body of that notification closes it without doing anything. The Files app is only opened if I click the "Open Files app" button at its bottom. We should making clicking the main body open the Files app as well. I think that the relevant code is in ui/file_manager/file_manager/background/js/device_handler.js, specifically DeviceHandler.Notification.DEVICE_NAVIGATION and DeviceHandler.Notification.prototype.showInternal_. Looking at https://developer.chrome.com/apps/notifications, I think we need to set isClickable in the options and add a handler for onClicked. This looks easy to do, but feel free to steal it from me if you want to do it yourself. :-)
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ec4093bbdec65e8fdc600a6b84c1e2a8c186fdc commit 0ec4093bbdec65e8fdc600a6b84c1e2a8c186fdc Author: derat <derat@chromium.org> Date: Thu Jan 26 22:49:42 2017 chromeos: Make filesystem mount notifications clickable. Make the bodies of the filesystem mount and import notifications clickable. Currently, clicking them dismisses them without doing anything. Also unify some duplicate code. BUG= 684095 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2645353005 Cr-Commit-Position: refs/heads/master@{#446477} [modify] https://crrev.com/0ec4093bbdec65e8fdc600a6b84c1e2a8c186fdc/ui/file_manager/file_manager/background/js/device_handler.js [modify] https://crrev.com/0ec4093bbdec65e8fdc600a6b84c1e2a8c186fdc/ui/file_manager/file_manager/background/js/device_handler_unittest.js
,
Jan 26 2017
,
Apr 6 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by derat@chromium.org
, Jan 24 2017