New issue
Advanced search Search tips

Issue 684091 link

Starred by 1 user
Status: Fixed
Owner:
jianli@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove popup overlays from MHTML archive

Project Member Reported by jianli@chromium.org, Jan 23 2017 
We should try to remove popup overlays from MHTML archive when it is saved in the background. This is because MHTML archive will only be opened in fully sandbox mode which will disable javascript execution and these popup overlays that obstruct users from viewing normal content cannot be dismissed.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec72fc4b04c800b1d54063d09b79350fdcd0cc15

commit ec72fc4b04c800b1d54063d09b79350fdcd0cc15
Author: jianli <jianli@chromium.org>
Date: Tue Jan 24 02:35:57 2017

Remove popup overlay from MHTML when requested

If the page is being loaded in background mode and saved to MHTML,
we should try to remove popup overlay that obstructs viewing the
normal content. This is controlled by MHTMLGenerationParams::
remove_popup_overlay.

BUG= 684091 
TEST=new tests added

Review-Url: https://codereview.chromium.org/2640923003
Cr-Commit-Position: refs/heads/master@{#445612}

[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_archiver.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_client_policy.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_model.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_test_archiver.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/components/offline_pages/core/offline_page_test_archiver.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/content/common/frame_messages.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/content/public/common/mhtml_generation_params.h
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/content/renderer/render_frame_impl.cc
[add] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/content/test/data/popup.html
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[add] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/third_party/WebKit/Source/web/tests/data/frameserialization/popup.html
[modify] https://crrev.com/ec72fc4b04c800b1d54063d09b79350fdcd0cc15/third_party/WebKit/public/web/WebFrameSerializer.h

Comment 2 by jianli@chromium.org, Jan 24 2017

Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 24 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce

commit dd7ad8044610e0c92d8cc3695c19bf78ec3013ce
Author: Jian Li <jianli@chromium.org>
Date: Tue Jan 24 22:07:48 2017

Merge to M57: Remove popup overlay from MHTML when requested

If the page is being loaded in background mode and saved to MHTML,
we should try to remove popup overlay that obstructs viewing the
normal content. This is controlled by MHTMLGenerationParams::
remove_popup_overlay.

BUG= 684091 
TEST=new tests added

Review-Url: https://codereview.chromium.org/2640923003
Cr-Commit-Position: refs/heads/master@{#445612}
(cherry picked from commit ec72fc4b04c800b1d54063d09b79350fdcd0cc15)

Review-Url: https://codereview.chromium.org/2656713002 .
Cr-Commit-Position: refs/branch-heads/2987@{#75}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_archiver.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_client_policy.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_model.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_test_archiver.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/components/offline_pages/core/offline_page_test_archiver.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/content/common/frame_messages.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/content/public/common/mhtml_generation_params.h
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/content/renderer/render_frame_impl.cc
[add] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/content/test/data/popup.html
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[add] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/third_party/WebKit/Source/web/tests/data/frameserialization/popup.html
[modify] https://crrev.com/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce/third_party/WebKit/public/web/WebFrameSerializer.h

Comment 5 by jianli@chromium.org, Jan 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment