git cl: eliding a patch set title shouldn’t warn the user |
||
Issue descriptionIn the below example I don’t want to add a title to the patch set. It shouldn’t add the extra step of asking me to confirm in that case (with the error message being incorrect). ~/buildbucket-plugin 💀 git cl upload Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... Presubmit checks passed. src/main/resources/static/buildbucket.js | 162 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------ test/buildbucket_test.html | 33 ++++++++++++++++++++++++-- 2 files changed, 124 insertions(+), 71 deletions(-) Title for patchset [Add unit tests for buildbucket.js]: WARNING: Patchset title may only contain alphanumeric chars and spaces. Cleaned up title: Add unit tests for buildbucketjs Press enter to continue, Ctrl+C to abort
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/856585ddeccffe6738ce55ec2cc43a9fcc2f1be1 commit 856585ddeccffe6738ce55ec2cc43a9fcc2f1be1 Author: Aaron Gable <agable@chromium.org> Date: Mon Jan 23 23:32:00 2017 Only prompt for clean titles if manually set We have to clean up the title, but if the user hasn't expressed any input about the title (i.e. it's one we autogenerated), then don't bother them by pointing it out. BUG= 684079 Change-Id: I8215e0a30f786466697fe1df178ca90e1980d9b0 Reviewed-on: https://chromium-review.googlesource.com/431162 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrew Bonventre <andybons@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/856585ddeccffe6738ce55ec2cc43a9fcc2f1be1/git_cl.py
,
Jan 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Jan 23 2017Status: Started (was: Assigned)