New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684078 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Media Remoting: Don't exit remoting if not enough data was buffered.

Project Member Reported by x...@chromium.org, Jan 23 2017

Issue description

When there is not enough data buffered for rendering, remote playback
may be paused/delayed. Don't exit remoting in this case.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/551abe8c8bf1d5276dd03e98615ceb928597d719

commit 551abe8c8bf1d5276dd03e98615ceb928597d719
Author: xjz <xjz@chromium.org>
Date: Mon Jan 23 23:31:19 2017

Media Remoting: Don't exit remoting if no enough data buffered.
When there is not enough data buffered for rendering, remote playback
may be paused/delayed. Don't exit remoting in this case.

BUG= 684078 

Review-Url: https://codereview.chromium.org/2648303003
Cr-Commit-Position: refs/heads/master@{#445542}

[modify] https://crrev.com/551abe8c8bf1d5276dd03e98615ceb928597d719/media/remoting/remote_renderer_impl.cc
[modify] https://crrev.com/551abe8c8bf1d5276dd03e98615ceb928597d719/media/remoting/remote_renderer_impl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173b3a82f7abf9c1edcb430900191e8997b29329

commit 173b3a82f7abf9c1edcb430900191e8997b29329
Author: xjz <xjz@chromium.org>
Date: Tue Jan 24 02:26:27 2017

Revert of Media Remoting: Don't exit remoting if no enough data buffered. (patchset #2 id:20001 of https://codereview.chromium.org/2648303003/ )

Reason for revert:
I just realized that this BufferingState is reported from receiver side. So the BUFFERING_HAVE_NOTHING state could also be caused by insufficient bandwidth condition, and should exit remoting. Revert this CL for now, and will re-think this issue.

Original issue's description:
> Media Remoting: Don't exit remoting if no enough data buffered.
> When there is not enough data buffered for rendering, remote playback
> may be paused/delayed. Don't exit remoting in this case.
>
> BUG= 684078 
>
> Review-Url: https://codereview.chromium.org/2648303003
> Cr-Commit-Position: refs/heads/master@{#445542}
> Committed: https://chromium.googlesource.com/chromium/src/+/551abe8c8bf1d5276dd03e98615ceb928597d719

TBR=miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 684078 

Review-Url: https://codereview.chromium.org/2648423004
Cr-Commit-Position: refs/heads/master@{#445609}

[modify] https://crrev.com/173b3a82f7abf9c1edcb430900191e8997b29329/media/remoting/remote_renderer_impl.cc
[modify] https://crrev.com/173b3a82f7abf9c1edcb430900191e8997b29329/media/remoting/remote_renderer_impl.h

Comment 3 by x...@chromium.org, Jan 24 2017

Status: WontFix (was: Started)
As explained in the reason for revert, this seems can be same as insufficient bandwidth issue that is already covered by current logic. Close this issue for now.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465aa743ef09328a83dc18b9089db35c9243ea52

commit 465aa743ef09328a83dc18b9089db35c9243ea52
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Fri Sep 15 22:05:15 2017

Media Remoting: Continue if waiting for buffering.

When there is not enough data provided by Demuxer, remote playback may
be delayed or paused. Don't exit media remoting in this case.

Bug:  684078 
Change-Id: I588b775c7cba841090f488aafbfa0723727e5d5c
Reviewed-on: https://chromium-review.googlesource.com/664197
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502398}
[modify] https://crrev.com/465aa743ef09328a83dc18b9089db35c9243ea52/media/remoting/courier_renderer.cc
[modify] https://crrev.com/465aa743ef09328a83dc18b9089db35c9243ea52/media/remoting/courier_renderer.h
[modify] https://crrev.com/465aa743ef09328a83dc18b9089db35c9243ea52/media/remoting/courier_renderer_unittest.cc
[modify] https://crrev.com/465aa743ef09328a83dc18b9089db35c9243ea52/media/remoting/demuxer_stream_adapter.cc
[modify] https://crrev.com/465aa743ef09328a83dc18b9089db35c9243ea52/media/remoting/demuxer_stream_adapter.h

Sign in to add a comment