Tracker for Media Remoting integration testing |
||||||||
Issue descriptionThe current vision here is to have both: 1. End-to-end tests: Most of the normal media stack's integration tests should be run using a full remoting pipeline sender <--> RPC <--> receiver set-up. This is to confirm the media pipeline behaves correctly whether it is playing back locally or through the remoting pipeline. The end-to-end tests should be testing normal use cases, known-breaking use cases (for correct fallback/abort functionality), and stress testing (such as rapid switching, high-volume data, etc.) 2. Media Router browser tests: Includes an extension that mocks a remoting receiver and confirms all startup/shutdown/RPC plumbing works throughout the renderer/browser process and extension API layer. OTOH, some big things that need to be done as a prerequisite: 1. Some/most of the receiver-side remoting code should be moved into the Chromium tree. We need to make sure any changes to code structure within the Chromium project is not bound by code that exists in external projects (sans public interfaces designed specifically for that). 2. Clean-up/consolidation of Cast extension APIs. In particular, we should stop sending control messages as plain strings that are parsed in the browser process. Our plethora of rather separate (and needing clean-up) internal extension APIs (streaming session, rtp, cast channel, etc.) should be consolidated into a simpler Mojo-based interface.
,
Mar 25 2017
xjz wrote two changes on this I still need to review. We are putting this on a very short-term hold as we work on other high-priority things.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60d4e0a63eb3f2be26aca1281be29c64b0f5c670 commit 60d4e0a63eb3f2be26aca1281be29c64b0f5c670 Author: xjz <xjz@chromium.org> Date: Fri Apr 07 01:37:49 2017 Media Remoting: End to end integration tests. Add end to end integration tests for Media Remoting. Refactors PipelineIntegrationTest to test both media and media remoting pipeline. Re-use current tests. No new tests are added in this CL. BUG= 684065 Review-Url: https://codereview.chromium.org/2692593002 Cr-Commit-Position: refs/heads/master@{#462739} [modify] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/BUILD.gn [add] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/end2end_test_renderer.cc [add] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/end2end_test_renderer.h [add] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/receiver.cc [add] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/receiver.h [add] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/stream_provider.cc [add] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/remoting/stream_provider.h [modify] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/test/BUILD.gn [modify] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/test/pipeline_integration_test.cc [modify] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/test/pipeline_integration_test_base.cc [modify] https://crrev.com/60d4e0a63eb3f2be26aca1281be29c64b0f5c670/media/test/pipeline_integration_test_base.h
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1b017627acf79bdb62b1fa273d45e87fed29b5b commit b1b017627acf79bdb62b1fa273d45e87fed29b5b Author: findit-for-me <findit-for-me@appspot.gserviceaccount.com> Date: Fri Apr 07 04:16:31 2017 Revert of Media Remoting: End to end integration tests. (patchset #4 id:120001 of https://codereview.chromium.org/2692593002/ ) Reason for revert: Findit identified CL at revision 462739 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYwZDRlMGE2M2ViM2YyYmUyNmFjYTEyODFiZTI5YzY0YjBmNWM2NzAM Original issue's description: > Media Remoting: End to end integration tests. > > Add end to end integration tests for Media Remoting. Refactors > PipelineIntegrationTest to test both media and media remoting pipeline. > Re-use current tests. No new tests are added in this CL. > > BUG= 684065 > > Review-Url: https://codereview.chromium.org/2692593002 > Cr-Commit-Position: refs/heads/master@{#462739} > Committed: https://chromium.googlesource.com/chromium/src/+/60d4e0a63eb3f2be26aca1281be29c64b0f5c670 TBR=miu@chromium.org,sandersd@chromium.org,xjz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 684065 Review-Url: https://codereview.chromium.org/2804183002 Cr-Commit-Position: refs/heads/master@{#462744} [modify] https://crrev.com/b1b017627acf79bdb62b1fa273d45e87fed29b5b/media/remoting/BUILD.gn [delete] https://crrev.com/c405301b70ada81d162e3c3051e63c0d487c0b94/media/remoting/end2end_test_renderer.cc [delete] https://crrev.com/c405301b70ada81d162e3c3051e63c0d487c0b94/media/remoting/end2end_test_renderer.h [delete] https://crrev.com/c405301b70ada81d162e3c3051e63c0d487c0b94/media/remoting/receiver.cc [delete] https://crrev.com/c405301b70ada81d162e3c3051e63c0d487c0b94/media/remoting/receiver.h [delete] https://crrev.com/c405301b70ada81d162e3c3051e63c0d487c0b94/media/remoting/stream_provider.cc [delete] https://crrev.com/c405301b70ada81d162e3c3051e63c0d487c0b94/media/remoting/stream_provider.h [modify] https://crrev.com/b1b017627acf79bdb62b1fa273d45e87fed29b5b/media/test/BUILD.gn [modify] https://crrev.com/b1b017627acf79bdb62b1fa273d45e87fed29b5b/media/test/pipeline_integration_test.cc [modify] https://crrev.com/b1b017627acf79bdb62b1fa273d45e87fed29b5b/media/test/pipeline_integration_test_base.cc [modify] https://crrev.com/b1b017627acf79bdb62b1fa273d45e87fed29b5b/media/test/pipeline_integration_test_base.h
,
Apr 19 2017
Ping xjz@: what's the status here?
,
Apr 19 2017
Both integration tests and browser tests are in reviewing. https://codereview.chromium.org/2808583002/ https://codereview.chromium.org/2724173002/
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/722e67b4d30548006c685f81bfcd6a88858168e1 commit 722e67b4d30548006c685f81bfcd6a88858168e1 Author: xjz <xjz@chromium.org> Date: Fri Apr 21 01:42:25 2017 RELAND: Media Remoting end to end integration tests. This is a re-land of https://codereview.chromium.org/2692593002/. Moved tests for media remoting pipeline out of general PipelineIntegrationTest. -------Description of original change follows------- Media Remoting: End to end integration tests. Add end to end integration tests for Media Remoting. Refactors PipelineIntegrationTest to test both media and media remoting pipeline. Re-use current tests. No new tests are added in this CL. BUG= 684065 Review-Url: https://codereview.chromium.org/2808583002 Cr-Commit-Position: refs/heads/master@{#466216} [modify] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/BUILD.gn [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/end2end_test_renderer.cc [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/end2end_test_renderer.h [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/integration_test.cc [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/receiver.cc [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/receiver.h [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/stream_provider.cc [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/remoting/stream_provider.h [modify] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/BUILD.gn [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/fake_encrypted_media.cc [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/fake_encrypted_media.h [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/mock_media_source.cc [add] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/mock_media_source.h [modify] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/pipeline_integration_test.cc [modify] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/pipeline_integration_test_base.cc [modify] https://crrev.com/722e67b4d30548006c685f81bfcd6a88858168e1/media/test/pipeline_integration_test_base.h
,
May 23 2017
What's the latest update on this?
,
May 23 2017
The browser tests CL(https://codereview.chromium.org/2724173002/) was hold off to avoid extra work and merging while a refactoring on mirroring/remoting is on-going.
,
Aug 14 2017
Any updates? Shall we change the milestone to M62?
,
Aug 14 2017
,
Oct 9 2017
,
Dec 1 2017
,
Dec 4 2017
At this point, we've taken this as far as we want to go. There is an in-progress refactoring that will allow us to further improve end-to-end test coverage with much less effort. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by anatolid@chromium.org
, Mar 22 2017