New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684064 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"Secure" chip persists when it shouldn't

Project Member Reported by nparker@chromium.org, Jan 23 2017

Issue description

I ran into this last week on M55 on linux, and now again randomly.  I can't repro it reliably.

I think it happens when I use a search-engine short cut ("cr" for chromium code search). I end up with the Secure chip and an editable omnibox. Whatever I type, it says Secure.  It goes away when I hit esc.
 
Screenshot from 2017-01-23 12:49:06.png
14.7 KB View Download

Comment 2 by est...@chromium.org, Jan 23 2017

Cc: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Ok, I've got a repro now (55.0.2883.87 linux):

* Visit a secure site. https://www.yahoo.com
* Press CTRL-K. For me, this puts focus in the omnibox and says "Search Google |"
* Hi BACKSPACE.  Now it says "Secure |" and you can type and it'll remain

If I start on an HTTP page, it does not say secure.

Comment 4 by est...@chromium.org, Jan 27 2017

Huh, I can't repro on 56 stable.

nparker, does that repro work consistently for you? Would you be able to try on 56 or later? I wonder if it got fixed already in 56.

Comment 5 by est...@chromium.org, Jan 27 2017

(Actually, nparker, I'm going to try bisecting this, so don't worry about it if it's not easy for you to test on >=56 right now.)
I can't repro on 57.0.2987.13 (linux/dev).

Comment 7 by est...@chromium.org, Jan 28 2017

Cc: -spqc...@chromium.org est...@chromium.org
Labels: -Pri-2 Pri-3
Owner: spqc...@chromium.org
Yeah I think this was fixed somewhere in M56 (I could reproduce on a 55.0.2883.87 build but can't on 56.0.2924.76), but my attempts to bisect ended in nonsense.

Bumping this over to spqchan@ in case she knows what might have fixed this and if there's a test for it.

I'll try to bisect again in the meantime.

Comment 8 by est...@chromium.org, Jan 28 2017

Oh, my previous bisect ended in nonsense because I got confused about what was "good" and "bad".

Looks like this was fixed, perhaps unintentionally, in https://chromiumcodereview.appspot.com/2435493003.

spqchan, could you please take a look and see if there's anything we need to do to make sure this doesn't regress? (e.g. add a unit test or structure the code to be more deliberate about this case or...?)
Sure thing! I'm planning to write tests for the security verbose on Mac ( Issue 687347 ). I can write them for Linux/Windows too
Labels: -Hotlist-HttpBad
Components: -UI>Browser>Omnibox>SecurityIndicators UI>Browser>Omnibox>SecurityIndicators>VerboseChip
Components: Tests>Missing
Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -Hotlist-EnamelAndFriendsFixIt
Status: WontFix (was: Assigned)

Sign in to add a comment