"Secure" chip persists when it shouldn't |
||||||||||
Issue description
I ran into this last week on M55 on linux, and now again randomly. I can't repro it reliably.
I think it happens when I use a search-engine short cut ("cr" for chromium code search). I end up with the Secure chip and an editable omnibox. Whatever I type, it says Secure. It goes away when I hit esc.
,
Jan 23 2017
,
Jan 27 2017
Ok, I've got a repro now (55.0.2883.87 linux): * Visit a secure site. https://www.yahoo.com * Press CTRL-K. For me, this puts focus in the omnibox and says "Search Google |" * Hi BACKSPACE. Now it says "Secure |" and you can type and it'll remain If I start on an HTTP page, it does not say secure.
,
Jan 27 2017
Huh, I can't repro on 56 stable. nparker, does that repro work consistently for you? Would you be able to try on 56 or later? I wonder if it got fixed already in 56.
,
Jan 27 2017
(Actually, nparker, I'm going to try bisecting this, so don't worry about it if it's not easy for you to test on >=56 right now.)
,
Jan 28 2017
I can't repro on 57.0.2987.13 (linux/dev).
,
Jan 28 2017
Yeah I think this was fixed somewhere in M56 (I could reproduce on a 55.0.2883.87 build but can't on 56.0.2924.76), but my attempts to bisect ended in nonsense. Bumping this over to spqchan@ in case she knows what might have fixed this and if there's a test for it. I'll try to bisect again in the meantime.
,
Jan 28 2017
Oh, my previous bisect ended in nonsense because I got confused about what was "good" and "bad". Looks like this was fixed, perhaps unintentionally, in https://chromiumcodereview.appspot.com/2435493003. spqchan, could you please take a look and see if there's anything we need to do to make sure this doesn't regress? (e.g. add a unit test or structure the code to be more deliberate about this case or...?)
,
Jan 31 2017
Sure thing! I'm planning to write tests for the security verbose on Mac ( Issue 687347 ). I can write them for Linux/Windows too
,
Mar 15 2017
,
Mar 15 2017
,
Jun 7 2017
,
Nov 10 2017
,
Feb 18 2018
,
May 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by nparker@chromium.org
, Jan 23 201714.7 KB
14.7 KB View Download