New issue
Advanced search Search tips

Issue 684063 link

Starred by 2 users
Status: Fixed
Owner:
pkl@chromium.org
Closed: Mar 2017
Cc:
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 681867



Sign in to add a comment

NativeAppNavigationController should stop using _tab to openAppStore.

Project Member Reported by pkl@chromium.org, Jan 23 2017 
This is part of a longer term clean up (Issue 681867). Tab class has an ivar of type id<StoreKitLauncher> that can be turned into a TabHelper object and access all information it needs via WebState.

However, NativeAppNavigationController needs to launch a SKStoreProductViewController UI which is currently handled by -[Tab openAppStore:]. This method needs to be removed from Tab and handled differently.

Comment 1 by pkl@chromium.org, Mar 7 2017

Status: Started (was: Assigned)

Comment 2 by pkl@chromium.org, Mar 7 2017 

Issue 546213 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b

commit d6e73e57a224c74a169abbcd8f2507fd1a5daa7b
Author: pkl <pkl@chromium.org>
Date: Wed Mar 08 15:56:51 2017

Introduced StoreKitTabHelper class

Removed _tab from NativeAppNavigationController as everything can
be obtained from WebState.

BUG= 684063 

Review-Url: https://codereview.chromium.org/2731553005
Cr-Commit-Position: refs/heads/master@{#455460}

[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/itunes_links/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/itunes_links/itunes_links_observer.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/itunes_links/itunes_links_observer_unittest.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/native_app_launcher/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm
[add] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/store_kit/BUILD.gn
[rename] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/store_kit/store_kit_launcher.h
[add] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/store_kit/store_kit_tab_helper.h
[add] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/store_kit/store_kit_tab_helper.mm
[add] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/store_kit/store_kit_tab_helper_unittest.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/downloads/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/downloads/download_manager_controller.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/browser/ui/settings/native_apps_collection_view_controller.h
[modify] https://crrev.com/d6e73e57a224c74a169abbcd8f2507fd1a5daa7b/ios/chrome/test/BUILD.gn

Comment 5 by pkl@chromium.org, Mar 9 2017

Status: Fixed (was: Started)
Instance variable _tab removed.
►

Sign in to add a comment