New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MD Settings: In manage password, website url focus outline is cut-off.

Project Member Reported by scottchen@chromium.org, Jan 23 2017

Issue description

Chrome Version: 58.0.2990.0 (Official Build) canary (64-bit)
OS: all

What steps will reproduce the problem?
(1) Go to Manage Password subpage
(2) Press Tab until the website URL is focused
(3) Observe the very slim focus outline.

What is the expected result?
The full focus outline is visible

What happens instead?
The focus outline is only partially visible


 
Screen Shot 2017-01-23 at 12.32.06 PM.png
59.7 KB View Download
Owner: scottchen@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8344f4e824e081eadcc29b79edaa40dbdfef3b4

commit f8344f4e824e081eadcc29b79edaa40dbdfef3b4
Author: scottchen <scottchen@chromium.org>
Date: Tue Jan 24 18:41:51 2017

MD Settings: fix focus outline getting cut off in manage password page

Using overflow:hidden around hyperlinks is causing focus outlines to get cut off. Switching to min-width: 0 has the same desired effect of forcing text-elide without cutting off the outline visuals.

BUG= 684059 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651813002
Cr-Commit-Position: refs/heads/master@{#445765}

[modify] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Status: Fixed (was: Started)

Sign in to add a comment