New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684048 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

init_params.activatable doesn't take effect in mus+ash

Project Member Reported by moshayedi@chromium.org, Jan 23 2017

Issue description

Setting init_params.activatable to ACTIVATABLE_NO doesn't make the widget not focusable.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9

commit c17142e8e1a64aa75c26b843c2ed23ebec9d39b9
Author: moshayedi <moshayedi@chromium.org>
Date: Thu Jan 26 21:50:39 2017

Set focusibility correctly when initializing a window in mus+ash.

Saves |init_params.CanActivate()| in mus properties, and calls
SetCanFocus() from WM just after creating the window.

BUG= 684048 

Review-Url: https://codereview.chromium.org/2650833002
Cr-Commit-Position: refs/heads/master@{#446460}

[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ash/mus/top_level_window_factory.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ash/mus/window_manager.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ash/mus/window_manager.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/mash/simple_wm/simple_wm.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/demo/mus_demo.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/test_utils.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_server_test_base.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_tree.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/test/aura_test_base.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/views/mus/mus_client.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/views/widget/widget.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/views/widget/widget.h

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9

commit c17142e8e1a64aa75c26b843c2ed23ebec9d39b9
Author: moshayedi <moshayedi@chromium.org>
Date: Thu Jan 26 21:50:39 2017

Set focusibility correctly when initializing a window in mus+ash.

Saves |init_params.CanActivate()| in mus properties, and calls
SetCanFocus() from WM just after creating the window.

BUG= 684048 

Review-Url: https://codereview.chromium.org/2650833002
Cr-Commit-Position: refs/heads/master@{#446460}

[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ash/mus/top_level_window_factory.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ash/mus/window_manager.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ash/mus/window_manager.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/mash/simple_wm/simple_wm.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/demo/mus_demo.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/test_utils.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_server_test_base.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_tree.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/aura/test/aura_test_base.h
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/views/mus/mus_client.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/views/widget/widget.cc
[modify] https://crrev.com/c17142e8e1a64aa75c26b843c2ed23ebec9d39b9/ui/views/widget/widget.h

Sign in to add a comment