New issue
Advanced search Search tips

Issue 684039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Find-in-page results from PDF pages returned in different form than from regular pages.

Project Member Reported by paulmeyer@chromium.org, Jan 23 2017

Issue description

Chrome Version: 57.0.2986.0
OS: All

What steps will reproduce the problem?
(1) Load any full-page PDF.
(2) Use find-in-page function to search for something on the page multiple times.
(3) Observe the resulting FindReply IPCs directly.

Essentially, for all regular pages, find next requests are replied to with two FindReply IPCs: the first to update the active match ordinal for the new match, and the second to report/confirm the number of matches and specify that it is the final update (to indicate that the total number of matches has not changed since the last search, and that no other replies are coming).

However, in the case of a PDF page, searching is handled by a PDF-specific find plugin instead of the regular infrastructure, and it behaves a bit differently. For initial find requests, the find replies look to be the same as for a regular page, but for find next requests, the plugin returns only a single reply with the new active match ordinal, and never specifies which reply is final. I discovered that this confuses tests, and probably other things as well that I haven't noticed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c287600d86c43dd0bcadfb042ec98242f49e36e

commit 8c287600d86c43dd0bcadfb042ec98242f49e36e
Author: paulmeyer <paulmeyer@chromium.org>
Date: Tue Jan 24 18:36:45 2017

Make PDFs return find replies in the same form as regular pages.

BUG= 684039 , 55421 

Review-Url: https://codereview.chromium.org/2651843005
Cr-Commit-Position: refs/heads/master@{#445763}

[modify] https://crrev.com/8c287600d86c43dd0bcadfb042ec98242f49e36e/pdf/pdfium/pdfium_engine.cc

Status: Fixed (was: Started)
Components: Internals>Plugins>PDF UI>Browser>FindInPage

Sign in to add a comment