Generate unified build information in cbuilbot metadata |
||||
Issue descriptionWith unified builds we generate an image that supports multiple models. At present the build metadata does not include information about this. Goldeneye will need to be told which models a build supports, so we need to add information to the metadata to communicate this.
,
Jan 24 2017
,
Jan 24 2017
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e0ed31fbe331d849312f9f6beebc88a0269c205b commit e0ed31fbe331d849312f9f6beebc88a0269c205b Author: Simon Glass <sjg@chromium.org> Date: Wed Jan 25 17:54:41 2017 cidb: Update readme files based on recent experience Update the files a little to explain a few things better, and for consistency of style. BUG= chromium:684023 TEST=none Change-Id: I66a3159f8274de02b338b917464bc35d70d87a3b Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/433139 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/e0ed31fbe331d849312f9f6beebc88a0269c205b/cidb/developer.readme [modify] https://crrev.com/e0ed31fbe331d849312f9f6beebc88a0269c205b/cidb/schema.dump.readme
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9cea52dab0b5cb9238cc2f97c1ec22ac9a05f10a commit 9cea52dab0b5cb9238cc2f97c1ec22ac9a05f10a Author: Simon Glass <sjg@chromium.org> Date: Wed Jan 25 19:38:34 2017 cidb: Sort and comment columns wrt BUILD_STATUS_KEYS As a step towards completing the TODO, sort the fields in the same order. BUG= chromium:684023 TEST=lib/cidb_integration_test Change-Id: I98f0530beb500b4757f1abfe100ea4b8867358b2 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/433140 Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/9cea52dab0b5cb9238cc2f97c1ec22ac9a05f10a/lib/cidb.py
,
Feb 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6691f137815eabaf5abcfd09fd8c3aa1cf88e96d commit 6691f137815eabaf5abcfd09fd8c3aa1cf88e96d Author: Simon Glass <sjg@chromium.org> Date: Sun Feb 05 20:33:35 2017 cidb: Drop the separate key list from GetBuildHistory() Complete this TODO by using BUILD_STATUS_KEYS instead. BUG= chromium:684023 TEST=lib/cidb_integration_test Change-Id: I64e0a4be15784d1848e932f75f15e8a1c004ffad Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/433142 Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/6691f137815eabaf5abcfd09fd8c3aa1cf88e96d/lib/cidb.py
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3e7ac8c565f01e5772537cd5df799c8e50ae95c2 commit 3e7ac8c565f01e5772537cd5df799c8e50ae95c2 Author: Simon Glass <sjg@chromium.org> Date: Mon Feb 06 22:50:33 2017 cidb: Add an __init__ method to StrictModeListener This currently produced a warning when uploading changes: W:206, 4: Class has no __init__ method (no-init) 13:09:29: ERROR: linter found errors in 1 files Add one to keep it happy. BUG= chromium:684023 TEST=lib/cidb_unittest && lib/cidb_integration_test Change-Id: I82be22d0f101160319c11043c3ccb9d08cf1adc8 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/433143 Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/3e7ac8c565f01e5772537cd5df799c8e50ae95c2/lib/cidb.py
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7adb3340320a46c3cebfaadf8676a25d35e6730d commit 7adb3340320a46c3cebfaadf8676a25d35e6730d Author: Simon Glass <sjg@chromium.org> Date: Wed Feb 08 04:14:35 2017 cbuildbot: Fix typo in testIgnoreExtractDependenciesError() This should say 'ignore'. Fix it. BUG= chromium:684023 TEST=cbuildbot/stages/build_stages_unittest Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: I15460af76f5ffb36422abb770314e3257110aa74 Reviewed-on: https://chromium-review.googlesource.com/439431 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/7adb3340320a46c3cebfaadf8676a25d35e6730d/cbuildbot/stages/build_stages_unittest.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6f03541636b3896244156ee007d2318f52f11634 commit 6f03541636b3896244156ee007d2318f52f11634 Author: Simon Glass <sjg@chromium.org> Date: Thu Feb 09 20:47:39 2017 cbuildbot: Add tests for firmware versions At present there is no test for the code that reads the firmware versions from the image and adds it to the metadata. Add a simple test. BUG= chromium:684023 TEST=cbuildbot/stages/build_stages_unittest Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Ifdca2fa26b9433ae5f6a9abda7dfbfd9afb59fe4 Reviewed-on: https://chromium-review.googlesource.com/439432 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/6f03541636b3896244156ee007d2318f52f11634/cbuildbot/stages/build_stages_unittest.py
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d1e896fdd731aae618188f5e14390b3d3ca8bcb9 commit d1e896fdd731aae618188f5e14390b3d3ca8bcb9 Author: Simon Glass <sjg@chromium.org> Date: Fri Feb 10 04:48:47 2017 cbuildbot: Add a 'unibuild' property to indicate a unified build We need to be able to distinguish a unified build (supporting multiple models) from a normal build (supporting only a single model). Add a property to the metadata for this. We can detected a unibuild because it has a master configuration file in the image. BUG= chromium:684023 TEST=cbuildbot/stages/build_stages_unittest && lib/cidb_integration_test Change-Id: Ie6563a8f8a93228261979e19d41f615f9504120c Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/431801 Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/d1e896fdd731aae618188f5e14390b3d3ca8bcb9/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/d1e896fdd731aae618188f5e14390b3d3ca8bcb9/cbuildbot/commands.py [modify] https://crrev.com/d1e896fdd731aae618188f5e14390b3d3ca8bcb9/lib/cidb.py [modify] https://crrev.com/d1e896fdd731aae618188f5e14390b3d3ca8bcb9/cbuildbot/stages/build_stages.py [modify] https://crrev.com/d1e896fdd731aae618188f5e14390b3d3ca8bcb9/cbuildbot/commands_unittest.py [modify] https://crrev.com/d1e896fdd731aae618188f5e14390b3d3ca8bcb9/lib/cidb_integration_test.py
,
Feb 13 2017
The unibuild property is showing up in builds now. For example: https://uberchromegw.corp.google.com/i/chromeos/builders/reef-paladin/builds/1427 going to artifacts and looking at metadata.json: unibuild: false,
,
Feb 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sjg@chromium.org
, Jan 23 2017Status: Assigned (was: Available)