New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684015 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable DeviceStartUpFlags for Auto-launched Kiosk

Project Member Reported by sduraisamy@chromium.org, Jan 23 2017

Issue description

In auto-launched kiosk mode, a policy called DeviceStartUpFlags is not applied when Chrome starts. The policy gets applied if Kiosk apps are manually launched or if auto-launched Kiosk app gets interrupted (Ctrl+Alt+S) and then allowed to start.

It is a priority request from CFM as well. One of our big Signage opportunity depends on this feature.

 

Comment 2 by xiy...@chromium.org, Jan 23 2017

Cc: achuith@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/2649903004/
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4265c9c4166bbc95b13c5eebae2ed307732857

commit 7c4265c9c4166bbc95b13c5eebae2ed307732857
Author: xiyuan <xiyuan@chromium.org>
Date: Mon Jan 23 21:08:31 2017

kiosk: Allow startup flags for kiosk sessions

Bail in RestartToApplyPerSessionFlagsIfNeed when running in kiosk
sessions to allow startup flags be applied.

BUG= 684015 

Review-Url: https://codereview.chromium.org/2649903004
Cr-Commit-Position: refs/heads/master@{#445483}

[modify] https://crrev.com/7c4265c9c4166bbc95b13c5eebae2ed307732857/chrome/browser/chromeos/login/session/user_session_manager.cc

Comment 4 by xiy...@chromium.org, Jan 23 2017

Labels: Merge-Request-57
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 23 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d95938eff5e6994ef155dcb66df0c20012d6313f

commit d95938eff5e6994ef155dcb66df0c20012d6313f
Author: Xiyuan Xia <xiyuan@google.com>
Date: Mon Jan 23 21:49:29 2017

Merge "kiosk: Allow startup flags for kiosk sessions"

> Bail in RestartToApplyPerSessionFlagsIfNeed when running in kiosk
> sessions to allow startup flags be applied.
>
> BUG= 684015 
>
> Review-Url: https://codereview.chromium.org/2649903004
> Cr-Commit-Position: refs/heads/master@{#445483}
> (cherry picked from commit 7c4265c9c4166bbc95b13c5eebae2ed307732857)

Review-Url: https://codereview.chromium.org/2654503003 .
Cr-Commit-Position: refs/branch-heads/2987@{#37}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d95938eff5e6994ef155dcb66df0c20012d6313f/chrome/browser/chromeos/login/session/user_session_manager.cc

Labels: Merge-Request-56
Tested this on 	9202.4.0;57.0.2987.8. The --disable-quic start-up flag is being propagated to within the Kiosk sessions. Will add more notes later. 
Could we merge this back to R56?

Project Member

Comment 8 by sheriffbot@chromium.org, Jan 25 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by gkihumba@google.com, Jan 25 2017

Labels: Merge-Approved-56
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 25 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2ba498082d4e9d972251db9bbf7df6e4ae5d643

commit f2ba498082d4e9d972251db9bbf7df6e4ae5d643
Author: Xiyuan Xia <xiyuan@google.com>
Date: Wed Jan 25 21:11:32 2017

Merge "kiosk: Allow startup flags for kiosk sessions"

> Bail in RestartToApplyPerSessionFlagsIfNeed when running in kiosk
> sessions to allow startup flags be applied.
>
> BUG= 684015 
>
> Review-Url: https://codereview.chromium.org/2649903004
> Cr-Commit-Position: refs/heads/master@{#445483}
> (cherry picked from commit 7c4265c9c4166bbc95b13c5eebae2ed307732857)

Review-Url: https://codereview.chromium.org/2654063003 .
Cr-Commit-Position: refs/branch-heads/2924@{#870}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/f2ba498082d4e9d972251db9bbf7df6e4ae5d643/chrome/browser/chromeos/login/session/user_session_manager.cc

Status: Fixed (was: Started)
Cc: harpreet@chromium.org mlight@chromium.org
Status: Verified (was: Fixed)
Verified in M-56 Beta build 9000.76.0.
Labels: -Hotlist-Merge-Review -Merge-Review-56

Sign in to add a comment