New issue
Advanced search Search tips

Issue 684010 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 676394



Sign in to add a comment

Convert audio tests in AudioBufferSource to testharness.

Project Member Reported by rtoy@chromium.org, Jan 23 2017 
Three files in AudioBufferSource tests save results as audio files.  These need to be completely rewritten if we want to use testharness.

See https://bugs.chromium.org/p/chromium/issues/detail?id=676394#c10 for a list.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e8a1e9931da82222b1661e4da3a45bf6aee7ebd

commit 6e8a1e9931da82222b1661e4da3a45bf6aee7ebd
Author: rtoy <rtoy@chromium.org>
Date: Wed Mar 22 19:28:36 2017

Convert remaining AudioBufferSource tests to testharness

Manually converted this test to testharness and new Audit.  Decided to
leave these tests alone keeping the reference output wav file.  This
ensures the finishAudioTest continues to work so that we can generate
wav files if necessary for future and current tests.

BUG= 684010 
TEST=audiobuffersource.html, audiobuffersource-loop-points.html,
audiobuffersource-multi-channels.html

Review-Url: https://codereview.chromium.org/2714853005
Cr-Commit-Position: refs/heads/master@{#458838}

[modify] https://crrev.com/6e8a1e9931da82222b1661e4da3a45bf6aee7ebd/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-points.html
[modify] https://crrev.com/6e8a1e9931da82222b1661e4da3a45bf6aee7ebd/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-multi-channels.html

Comment 2 by rtoy@chromium.org, Mar 23 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment