New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684005 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

MD Settings: change simple out-links from "window.open" to "a[href]"

Project Member Reported by scottchen@chromium.org, Jan 23 2017

Issue description

In MD settings, there are many items that link out to external pages.
Currently, several <div>s has an on-tap handler that just use window.open() to go to the external page. 

For example, in manage_a11y_page.html:
<div class="settings-box two-line" on-tap="onMoreFeaturesTap_" actionable>
 ...

in manage_ally_page.js:
onMoreFeaturesTap_: function() {
  window.open(
    'https://chrome.google.com/webstore/category/collection/accessibility');
}

You can find several more by grepping the project for "window.open".

Simple out-linking elements like these should be converted to <a href=[[url]]>. Its semantically more suitable, but more importantly, we'll get the benefit all the built-in <a> interactions working correctly, such as 
- middle mouse button clicks
- right click to copy url
- accessibility (tabbable by default)


 
Cc: tbuck...@chromium.org dbeam@chromium.org michae...@chromium.org
Labels: Hotlist-MD-Settings-General OS-All
Status: Available (was: Untriaged)
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3e69c366f3e5c247276fec6c1dba93106f14ba9

commit c3e69c366f3e5c247276fec6c1dba93106f14ba9
Author: scottchen <scottchen@chromium.org>
Date: Tue Apr 25 23:59:21 2017

MD Settings: change outlinks to actually use <a>

BUG= 684005 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2825493003
Cr-Commit-Position: refs/heads/master@{#467169}

[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/a11y_page/a11y_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/people_page/sync_browser_proxy.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/printing_page/cloud_printers.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/c3e69c366f3e5c247276fec6c1dba93106f14ba9/chrome/browser/resources/settings/settings_vars_css.html

Status: Fixed (was: Started)

Sign in to add a comment