In MD settings, there are many items that link out to external pages.
Currently, several <div>s has an on-tap handler that just use window.open() to go to the external page.
For example, in manage_a11y_page.html:
<div class="settings-box two-line" on-tap="onMoreFeaturesTap_" actionable>
...
in manage_ally_page.js:
onMoreFeaturesTap_: function() {
window.open(
'https://chrome.google.com/webstore/category/collection/accessibility');
}
You can find several more by grepping the project for "window.open".
Simple out-linking elements like these should be converted to <a href=[[url]]>. Its semantically more suitable, but more importantly, we'll get the benefit all the built-in <a> interactions working correctly, such as
- middle mouse button clicks
- right click to copy url
- accessibility (tabbable by default)
Comment 1 by scottchen@chromium.org
, Jan 23 2017