New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683990 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Jan 2017
Cc:
█ zkoch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add metrics for the CanMakePayment method.

Project Member Reported by se...@chromium.org, Jan 23 2017 
We want to know:

1- The usage of that method in the wild.

2- How the return value affects whether the Payment Request is shown to the user

3- See how the return value affects the completion of the PR if it is shown to the user.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f634c72e1f91fe2a142e922691867546362ea1f

commit 3f634c72e1f91fe2a142e922691867546362ea1f
Author: sebsg <sebsg@chromium.org>
Date: Wed Jan 25 19:44:17 2017

[Payments] Add CanMakePayment metrics.

BUG= 683990 

Review-Url: https://codereview.chromium.org/2642213005
Cr-Commit-Position: refs/heads/master@{#446093}

[modify] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/android/java_sources.gni
[add] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[add] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerUnitTest.java
[add] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/test/data/payments/can_make_payment_metrics.js
[add] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/chrome/test/data/payments/payment_request_can_make_payment_metrics_test.html
[modify] https://crrev.com/3f634c72e1f91fe2a142e922691867546362ea1f/tools/metrics/histograms/histograms.xml

Comment 2 by se...@chromium.org, Jan 26 2017

Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/820ff9a94d5dda86537f0435b4ab6ecc4d203781

commit 820ff9a94d5dda86537f0435b4ab6ecc4d203781
Author: sebsg <sebsg@chromium.org>
Date: Thu Jan 26 20:37:40 2017

[Payments] Add CanMakePayment metrics.

BUG= 683990 

Review-Url: https://codereview.chromium.org/2642213005
Cr-Commit-Position: refs/heads/master@{#446093}
(cherry picked from commit 3f634c72e1f91fe2a142e922691867546362ea1f)

Review-Url: https://codereview.chromium.org/2658103002 .
Cr-Commit-Position: refs/branch-heads/2987@{#117}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/android/java_sources.gni
[add] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[add] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerUnitTest.java
[add] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/test/data/payments/can_make_payment_metrics.js
[add] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/chrome/test/data/payments/payment_request_can_make_payment_metrics_test.html
[modify] https://crrev.com/820ff9a94d5dda86537f0435b4ab6ecc4d203781/tools/metrics/histograms/histograms.xml

Comment 5 by se...@chromium.org, Jan 27 2017

Status: Fixed (was: Started)

Comment 6 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment