Issue 683983 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	eugene...@chromium.org
Closed:	Jan 2017
Cc:	marq@chromium.org ios-bugs@chromium.org
Components:	Test>iOS
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Feature

Rename CRWWebStateDelegateStub to CRWWebStateDelegateMock

Project Member Reported by eugene...@chromium.org, Jan 23 2017

Issue description

This class is a subclass of OCMockComplexTypeHelper and should be named mock.

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21465d6d72621e99b6c25c161db19d3ab0a54fcd

commit 21465d6d72621e99b6c25c161db19d3ab0a54fcd
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Jan 26 16:42:55 2017

Renamed CRWWebStateDelegateStub to CRWMockWebStateDelegate.

BUG= 683983 

Review-Url: https://codereview.chromium.org/2650913008
Cr-Commit-Position: refs/heads/master@{#446351}

[modify] https://crrev.com/21465d6d72621e99b6c25c161db19d3ab0a54fcd/ios/web/BUILD.gn
[rename] https://crrev.com/21465d6d72621e99b6c25c161db19d3ab0a54fcd/ios/web/public/test/crw_mock_web_state_delegate.h
[rename] https://crrev.com/21465d6d72621e99b6c25c161db19d3ab0a54fcd/ios/web/public/test/crw_mock_web_state_delegate.mm
[modify] https://crrev.com/21465d6d72621e99b6c25c161db19d3ab0a54fcd/ios/web/web_state/web_state_delegate_bridge_unittest.mm

Comment 2 by eugene...@chromium.org, Jan 27 2017

Status: Fixed (was: Assigned)

►

Issue 683983 link

Issue metadata

Rename CRWWebStateDelegateStub to CRWWebStateDelegateMock

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

Comment 1 Deleted

Comment 2 by eugene...@chromium.org, Jan 27 2017

Comment 2 Deleted

Sign in to add a comment