New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683972 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Jan 2017
Cc:
█ bauerb@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

On NTP suggestion dismissal, the new first or last card of the section shows the wrong corner type

Project Member Reported by dgn@chromium.org, Jan 23 2017 
When the first or last card of a section is dismissed, the one that becomes the new first or last should update its background style from "card with another card above and/or below" to "card without a card above and/or below"
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60311d47f627e94d7d47dd5548ac684263ff0762

commit 60311d47f627e94d7d47dd5548ac684263ff0762
Author: dgn <dgn@chromium.org>
Date: Fri Jan 27 18:19:08 2017

[NTP Client] Fix card style when a neighbour is added or removed

BUG= 683972 

Review-Url: https://codereview.chromium.org/2651743002
Cr-Commit-Position: refs/heads/master@{#446711}

[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java
[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java
[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/60311d47f627e94d7d47dd5548ac684263ff0762/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

Comment 2 by dgn@chromium.org, Jan 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment