New issue
Advanced search Search tips

Issue 683963 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jul 11
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 341477



Sign in to add a comment

Password import / export does not handle Android credentials correctly

Project Member Reported by jdoerrie@chromium.org, Jan 23 2017 
Chrome Version: 55.0.2883.87
OS: Linux

What steps will reproduce the problem?
(1) Export passwords containing at least one Android credential
(2) Delete the Android credential
(3) Import Android credential from the file exported in step (1)

What is the expected result?
Credential should reappear in the password list including a human readable description.

What happens instead?
Credential reappears, but is shown as android://...com.example.foo
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/501aeaf33dca3248d44bc9d7d5979d34e9f68025

commit 501aeaf33dca3248d44bc9d7d5979d34e9f68025
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Jul 11 12:28:21 2017

Set correct signon_realm during import of Android credentials

This change fixes the PasswordCSVReader to properly set the signon_realm
of Android credentials when importing them.

Bug:  683963 
Change-Id: I447d1393c1aa179f07737382e03ede2f8f056139
Reviewed-on: https://chromium-review.googlesource.com/566799
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485605}
[modify] https://crrev.com/501aeaf33dca3248d44bc9d7d5979d34e9f68025/components/password_manager/core/browser/import/password_csv_reader.cc
[modify] https://crrev.com/501aeaf33dca3248d44bc9d7d5979d34e9f68025/components/password_manager/core/browser/import/password_csv_reader_unittest.cc
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11

Status: Archived (was: Available)
This issue has been available for more than 365 days with no owner or cc list, so archiving this bug. Please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment