New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683949 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Tracking: Many InstantExtendedTest.* tests are disabled/flaky

Project Member Reported by treib@chromium.org, Jan 23 2017

Issue description

Many tests in InstantExtendedTest.* are disabled due to flakiness:
SearchDoesntReuseInstantTab
NoThemeBackgroundChangeEventOnTabSwitch
SendThemeBackgroundChangedEvent
NavigateBackToNTP
DispatchMVChangeEventWhileNavigatingBackToNTP
SetPrefetchQuery
ClearPrefetchedResults

Some of these have been disabled for a very long time; it's not clear if they are still flaky (or don't work at all anymore).
The tests related to Instant's prerendering might become obsolete mid-term, since there are plans to deprecate prerendering as a whole.


There is also InstantExtendedManualTest, which I haven't been able to get running. It's not clear if I'm holding it wrong, or it has rotted.
 

Comment 1 by fi...@chromium.org, Feb 6 2017

Labels: zine-triaged

Comment 2 by treib@chromium.org, Oct 12 2017

Prerendering is gone and many of these tests have been removed. The following tests still exist (and are still disabled):

NoThemeBackgroundChangeEventOnTabSwitch
SendThemeBackgroundChangedEvent
NavigateBackToNTP
DispatchMVChangeEventWhileNavigatingBackToNTP

Comment 3 by treib@chromium.org, Nov 27 2017

Status: Started (was: Assigned)
DispatchMVChangeEventWhileNavigatingBackToNTP was reenabled and seems to be stable. That leaves:

NoThemeBackgroundChangeEventOnTabSwitch
SendThemeBackgroundChangedEvent
Tracked in  bug 335297 , and both recently confirmed to still be flaky.

NavigateBackToNTP
Tracked in  bug 253092 , and apparently disabled since 2013. I'll try reenabling, maybe it has been fixed along with DispatchMVChangeEventWhileNavigatingBackToNTP in the meantime.

Comment 4 by treib@chromium.org, Nov 30 2017

Status: Fixed (was: Started)
Only the InstantThemeTests remain, everything else has either been reenabled or deleted. Those are tracked in  bug 335297 , so closing this tracking bug.
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment