Chrome Version: 57.2987
What steps will reproduce the problem?
(1) After storing a password for http://ericlawrence.com/regs/login.asp, revisit the page.
(2) Hover the "Form not secure" warning shown on autofill on page load
What is the expected result? Nothing happens
What happens instead? Autofilled password disappears
I think the problem is that the lines below were added *after* ClearPreviewedForm() instead of before it.
void PasswordAutofillManager::DidSelectSuggestion(const base::string16& value,
int identifier) {
ClearPreviewedForm();
+ if (identifier == autofill::POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE)
+ return;
This bug /might/ not be relevant because it sounds like the plan is to get rid of the on-load FNS notification for M57 due to other bugs?
Comment 1 by elawrence@chromium.org
, Jan 23 2017I've confirmed that swapping the order of those lines helps, but doesn't fully resolve the problem. The remaining problem is that if you hover that entry, then move the mouse out of the flyout, the form also clears. That's because inside void AutofillPopupControllerImpl::SetSelectedLine(int selected_line) { we have the lines if (selected_line_ != kNoSelection) { delegate_->DidSelectSuggestion(suggestions_[selected_line_].value, suggestions_[selected_line_].frontend_id); } else { delegate_->ClearPreviewedForm(); // <--- Problematic } } That appears to be a default behavior of the password manager flyout, so we'd probably want to get advice from the password manager UX team to decide whether we should change it.