New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683923 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

UrlManagerTest#testAddUrlGarbageCollectsForSize is flaky

Project Member Reported by joh...@chromium.org, Jan 23 2017

Issue description

Comment 1 by joh...@chromium.org, Jan 23 2017

The cause is a little unclear, but the stdio mentions ConcurrentModificationException.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1079d8a721465cf5626bfe0f1e4646eaad644829

commit 1079d8a721465cf5626bfe0f1e4646eaad644829
Author: johnme <johnme@chromium.org>
Date: Mon Jan 23 15:51:15 2017

Mark UrlManagerTest#testAddUrlGarbageCollectsForSize flaky

BUG= 683923 
TBR=cco3@chromium.org,nyquist@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2652703002
Cr-Commit-Position: refs/heads/master@{#445382}

[modify] https://crrev.com/1079d8a721465cf5626bfe0f1e4646eaad644829/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbc684353acc634cb47b87bc945d0e5158841f1

commit 9bbc684353acc634cb47b87bc945d0e5158841f1
Author: mattreynolds <mattreynolds@chromium.org>
Date: Mon Jan 30 21:18:28 2017

Ensure message listeners invoke UrlManager on UI thread

To avoid concurrency issues, all calls to UrlManager must be made on the
main thread. This CL touches the BackgroundMessageListener in
PhysicalWebBleClient.

BUG= 683923 

Review-Url: https://codereview.chromium.org/2658573006
Cr-Commit-Position: refs/heads/master@{#447066}

[modify] https://crrev.com/9bbc684353acc634cb47b87bc945d0e5158841f1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbc684353acc634cb47b87bc945d0e5158841f1

commit 9bbc684353acc634cb47b87bc945d0e5158841f1
Author: mattreynolds <mattreynolds@chromium.org>
Date: Mon Jan 30 21:18:28 2017

Ensure message listeners invoke UrlManager on UI thread

To avoid concurrency issues, all calls to UrlManager must be made on the
main thread. This CL touches the BackgroundMessageListener in
PhysicalWebBleClient.

BUG= 683923 

Review-Url: https://codereview.chromium.org/2658573006
Cr-Commit-Position: refs/heads/master@{#447066}

[modify] https://crrev.com/9bbc684353acc634cb47b87bc945d0e5158841f1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbc684353acc634cb47b87bc945d0e5158841f1

commit 9bbc684353acc634cb47b87bc945d0e5158841f1
Author: mattreynolds <mattreynolds@chromium.org>
Date: Mon Jan 30 21:18:28 2017

Ensure message listeners invoke UrlManager on UI thread

To avoid concurrency issues, all calls to UrlManager must be made on the
main thread. This CL touches the BackgroundMessageListener in
PhysicalWebBleClient.

BUG= 683923 

Review-Url: https://codereview.chromium.org/2658573006
Cr-Commit-Position: refs/heads/master@{#447066}

[modify] https://crrev.com/9bbc684353acc634cb47b87bc945d0e5158841f1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/24d79bf8ddf913ab29e675cae14d7e05ecc732be

commit 24d79bf8ddf913ab29e675cae14d7e05ecc732be
Author: Matt Reynolds <mattreynolds@google.com>
Date: Fri Jan 27 00:27:28 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/24d79bf8ddf913ab29e675cae14d7e05ecc732be

commit 24d79bf8ddf913ab29e675cae14d7e05ecc732be
Author: Matt Reynolds <mattreynolds@google.com>
Date: Fri Jan 27 00:27:28 2017

Labels: Merge-Request-57
Cc: cco3@chromium.org
Owner: mattreynolds@chromium.org
Status: Started (was: Assigned)
We'd like to merge these changes for M57:

https://codereview.chromium.org/2658573006

https://chrome-internal.googlesource.com/clank/internal/apps/+/24d79bf8ddf913ab29e675cae14d7e05ecc732be
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 31 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
The fix is in master and cherry-picked to M57 branch (2987).
Issue 684674 has been merged into this issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Feb 6 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-57

Sign in to add a comment