New issue
Advanced search Search tips

Issue 683922 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

enable spellcheck by default on trunk for M57+

Project Member Reported by timvolod...@chromium.org, Jan 23 2017

Issue description

Enable spellcheck by default on M57 for >512MB devices. This is already running in M56 via finch, so should be now also enabled on trunk.

 
Summary: enable spellcheck by default on trunk for M57+ (was: enable spellcheck by default for M57+)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9a2649f4d349f42acc658d90cc78ef7b170d87

commit be9a2649f4d349f42acc658d90cc78ef7b170d87
Author: timvolodine <timvolodine@chromium.org>
Date: Mon Jan 23 20:10:23 2017

[Android] Enable spellcheck on non low-end devices by default.

Currently spellcheck is being rolled out to all builds of M56 via
finch. This patch ensures spellcheck functionality continues to be
on for M57 and up on non low-end devices (i.e. having > 512MB RAM).
Also ensure that spellcheck can be disabled/enabled on non low-end
devices via chrome://flags.

BUG=629609, 683922 

Review-Url: https://codereview.chromium.org/2636843004
Cr-Commit-Position: refs/heads/master@{#445454}

[modify] https://crrev.com/be9a2649f4d349f42acc658d90cc78ef7b170d87/chrome/browser/about_flags.cc
[modify] https://crrev.com/be9a2649f4d349f42acc658d90cc78ef7b170d87/components/spellcheck/common/spellcheck_features.cc
[modify] https://crrev.com/be9a2649f4d349f42acc658d90cc78ef7b170d87/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b628695210d74bb18ad5b818681413afbdfde26

commit 2b628695210d74bb18ad5b818681413afbdfde26
Author: timvolodine <timvolodine@chromium.org>
Date: Tue Jan 24 19:49:16 2017

[Android] Enable spellcheck on non low-end devices by default.

Merge to M57 (2987)

Currently spellcheck is being rolled out to all builds of M56 via
finch. This patch ensures spellcheck functionality continues to be
on for M57 and up on non low-end devices (i.e. having > 512MB RAM).
Also ensure that spellcheck can be disabled/enabled on non low-end
devices via chrome://flags.

BUG=629609, 683922 
TBR=tobiasjs@chromium.org,groby@chromium.org,isherman@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2636843004
Cr-Commit-Position: refs/heads/master@{#445454}
(cherry picked from commit be9a2649f4d349f42acc658d90cc78ef7b170d87)

Review-Url: https://codereview.chromium.org/2650133003
Cr-Commit-Position: refs/branch-heads/2987@{#70}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/2b628695210d74bb18ad5b818681413afbdfde26/chrome/browser/about_flags.cc
[modify] https://crrev.com/2b628695210d74bb18ad5b818681413afbdfde26/components/spellcheck/common/spellcheck_features.cc
[modify] https://crrev.com/2b628695210d74bb18ad5b818681413afbdfde26/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment