enable spellcheck by default on trunk for M57+ |
||||||
Issue descriptionEnable spellcheck by default on M57 for >512MB devices. This is already running in M56 via finch, so should be now also enabled on trunk.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be9a2649f4d349f42acc658d90cc78ef7b170d87 commit be9a2649f4d349f42acc658d90cc78ef7b170d87 Author: timvolodine <timvolodine@chromium.org> Date: Mon Jan 23 20:10:23 2017 [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609, 683922 Review-Url: https://codereview.chromium.org/2636843004 Cr-Commit-Position: refs/heads/master@{#445454} [modify] https://crrev.com/be9a2649f4d349f42acc658d90cc78ef7b170d87/chrome/browser/about_flags.cc [modify] https://crrev.com/be9a2649f4d349f42acc658d90cc78ef7b170d87/components/spellcheck/common/spellcheck_features.cc [modify] https://crrev.com/be9a2649f4d349f42acc658d90cc78ef7b170d87/tools/metrics/histograms/histograms.xml
,
Jan 23 2017
,
Jan 23 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b628695210d74bb18ad5b818681413afbdfde26 commit 2b628695210d74bb18ad5b818681413afbdfde26 Author: timvolodine <timvolodine@chromium.org> Date: Tue Jan 24 19:49:16 2017 [Android] Enable spellcheck on non low-end devices by default. Merge to M57 (2987) Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609, 683922 TBR=tobiasjs@chromium.org,groby@chromium.org,isherman@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2636843004 Cr-Commit-Position: refs/heads/master@{#445454} (cherry picked from commit be9a2649f4d349f42acc658d90cc78ef7b170d87) Review-Url: https://codereview.chromium.org/2650133003 Cr-Commit-Position: refs/branch-heads/2987@{#70} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/2b628695210d74bb18ad5b818681413afbdfde26/chrome/browser/about_flags.cc [modify] https://crrev.com/2b628695210d74bb18ad5b818681413afbdfde26/components/spellcheck/common/spellcheck_features.cc [modify] https://crrev.com/2b628695210d74bb18ad5b818681413afbdfde26/tools/metrics/histograms/histograms.xml
,
Jan 26 2017
,
Apr 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by timvolod...@chromium.org
, Jan 23 2017