New issue
Advanced search Search tips

Issue 683920 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chromad: Use "Chromium OS" policies for non-branded builds

Project Member Reported by tnagel@chromium.org, Jan 23 2017

Issue description

Currently, the authpolicyd parser is looking for "Chrome OS" policies independent of the build type.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c3c59fab19af9ced86c52906bc04568e05a43bc1

commit c3c59fab19af9ced86c52906bc04568e05a43bc1
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Jan 24 09:49:01 2017

authpolicy: Fix using proper registry keys for Chromium builds

Reads the lsb-release flags to determine whether the build is Chrome
branded or not. This allows authpolicy to use different registry keys
based on branding.

BUG= chromium:683920 
TEST=Tested that lsb-release flags toggle keys as expected.

Change-Id: I02d85ed09eb98a92e3be6523995ae956d480a4e8
Reviewed-on: https://chromium-review.googlesource.com/430691
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/c3c59fab19af9ced86c52906bc04568e05a43bc1/authpolicy/policy/policy_encoder_helper.cc
[modify] https://crrev.com/c3c59fab19af9ced86c52906bc04568e05a43bc1/authpolicy/authpolicy_parser_main.cc

Comment 2 by tnagel@chromium.org, Jan 31 2017

Status: Fixed (was: Assigned)
This looks done.
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment