New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683915 link

Starred by 1 user
Status: Archived
Owner:
dmazz...@chromium.org
Closed: Jan 2017
Cc:
█ warx@chromium.org
jamescook@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

interactive_ui_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by se...@chromium.org, Jan 23 2017 
These tests have been failing over 50 times consecutively:

TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.VolumeSlider/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.VolumeSlider/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateAppLauncher/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateAppLauncher/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1

Found this CL that I think is the culprit:
https://codereview.chromium.org/2601333002

Comment 1 by jamescook@chromium.org, Jan 23 2017

Cc: jamescook@chromium.org warx@chromium.org
Status: Assigned (was: Available)
+chromeos gardeners

Comment 2 Deleted

Comment 3 by se...@chromium.org, Jan 23 2017 

Reverting it now: https://codereview.chromium.org/2650733002/
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4bf2e0d584f7b56059629037d714bf9d4b5abf

commit 8f4bf2e0d584f7b56059629037d714bf9d4b5abf
Author: sebsg <sebsg@chromium.org>
Date: Mon Jan 23 19:12:32 2017

Revert of Update json_schema_compiler to handle the Automation extension API (patchset #12 id:220001 of https://codereview.chromium.org/2601333002/ )

Reason for revert:
interactive_uitests failing for 50 times in a row

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29?numbuilds=100

see  crbug.com/683915 

Original issue's description:
> Update json_schema_compiler to handle the Automation extension API
>
> This allows the automation externs file to be fully autogenerated.
>
> Lots of tweaks to ChromeVox were required since we've been working with a
> hand-tweaked externs file for a while.
>
> BUG=none
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2601333002
> Cr-Commit-Position: refs/heads/master@{#445146}
> Committed: https://chromium.googlesource.com/chromium/src/+/f1cbfff18b19ff99310ffbfb94ca75462da7a859

TBR=dbeam@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 683915 

Review-Url: https://codereview.chromium.org/2650733002
Cr-Commit-Position: refs/heads/master@{#445428}

[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js
[add] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_object_constructor_installer.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[delete] https://crrev.com/ffa7fb44867a78ee1912510c2bfd91b5d432858f/chrome/browser/resources/chromeos/chromevox/cvox2/background/custom_automation_event.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/active_tab/background.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/desktop/actions.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/desktop/desktop.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/desktop/focus_views.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/desktop/load_tabs.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/generated/generated_trees.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/actions.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/document_selection.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/events.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/tools/json_schema_compiler/idl_schema.py
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/tools/json_schema_compiler/idl_schema_test.py
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/tools/json_schema_compiler/js_externs_generator.py
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/tools/json_schema_compiler/js_externs_generator_test.py
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/tools/json_schema_compiler/js_util.py
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/tools/json_schema_compiler/model.py
[modify] https://crrev.com/8f4bf2e0d584f7b56059629037d714bf9d4b5abf/ui/accessibility/PRESUBMIT.py

Comment 5 by waff...@chromium.org, Jan 23 2017

Labels: -Hotlist-Sheriff-Chromium
Cleared after revert, removing from queue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5964242ae4c92988b391db18328b162937f8da3b

commit 5964242ae4c92988b391db18328b162937f8da3b
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Jan 25 23:17:46 2017

Re-land: Update json_schema_compiler to handle the Automation extension API

Originally landed as r445146: https://codereview.chromium.org/2601333002
Reverted as r445428.

Fixed by deferring the initialization of DesktopAutomationHandler
to match the previous behavior that was significant when tests are
run in debug mode.

This allows the automation externs file to be fully autogenerated.

Lots of tweaks to ChromeVox were required since we've been working with a
hand-tweaked externs file for a while.

BUG= 683915 
TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,dbeam@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/f1cbfff18b19ff99310ffbfb94ca75462da7a859
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2649373002
Cr-Commit-Position: refs/heads/master@{#446160}

[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_object_constructor_installer.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[add] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/custom_automation_event.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/active_tab/background.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/desktop/actions.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/desktop/desktop.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/desktop/focus_views.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/desktop/load_tabs.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/generated/generated_trees.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/actions.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/document_selection.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/events.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/tools/json_schema_compiler/idl_schema.py
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/tools/json_schema_compiler/idl_schema_test.py
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/tools/json_schema_compiler/js_externs_generator.py
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/tools/json_schema_compiler/js_externs_generator_test.py
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/tools/json_schema_compiler/js_util.py
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/tools/json_schema_compiler/model.py
[modify] https://crrev.com/5964242ae4c92988b391db18328b162937f8da3b/ui/accessibility/PRESUBMIT.py

Comment 7 by dmazz...@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)
Re-landed and passing now.

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 10 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment