Show detected casts different to personal casts to prevent confusion
Reported by
tic...@gmail.com,
Jan 23 2017
|
|||||||||||
Issue description
Chrome Version : 57.0.2970.0
OS Version: 9150.0.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
1. Use a busy network with many cast devices in use
2. Break into a sweat when you see the system area notification that the Desktop is being cast to a Public Chromecast device and stop it casting
3. Realise that what you are seeing is 'others' casting on the same network
What is the expected result?
You are able to see clearly casts that you might have triggered inadvertently
What happens instead of that?
There is no way to tell the difference between a personal cast event and someone else's.
Please provide any additional information below. Attach a screenshot if
possible.
This was witnessed in my college and I stopped many casts before realising what was going on. This I suppose is trying to match the experience on mobile devices but it is far clearer on mobile devices whether it is you doing the casting. That clarity needs to be brought to Chrome OS too.
UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9150.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2970.0 Safari/537.36
,
Jan 26 2017
Jacob, is this something you could take a look at? This dialog should not be showing non-local routes.
,
Jan 27 2017
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e949b4732c4d76670a39719a73422ed0dc2976c commit 4e949b4732c4d76670a39719a73422ed0dc2976c Author: jdufault <jdufault@chromium.org> Date: Mon Jan 30 20:07:58 2017 cros: Fix various small issues with cast tray entry. 673023: Do not show TrayCast active state until we have media router information to prevent short visual glitch where we are "Casting to unknown receiver". 683908: Only show local routes 671094: Better accessibility label for Stop casting button. BUG=673023, 683908 , 671094 Review-Url: https://codereview.chromium.org/2656003006 Cr-Commit-Position: refs/heads/master@{#447045} [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/ash/ash_strings.grd [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/ash/common/system/chromeos/cast/tray_cast.cc [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/ash/common/system/chromeos/screen_security/screen_tray_item.h [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
,
Jan 30 2017
Many thanks for doing this - much appreciated. - Mike
,
Jan 30 2017
Happy to help :)
,
Feb 14 2017
Issue 682575 has been merged into this issue.
,
Feb 14 2017
Issue 691896 has been merged into this issue.
,
Feb 15 2017
,
Feb 15 2017
Issue 679744 has been merged into this issue.
,
Feb 16 2017
Do we know when this will roll out to stable?
,
Feb 16 2017
m58
,
Feb 16 2017
I'm going to submit a merge request for m57, since there have been quite a few duplicated bugs for this.
,
Feb 16 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dbca8ec13dcf78b1c689018527315856c2b0a95 commit 1dbca8ec13dcf78b1c689018527315856c2b0a95 Author: Jacob Dufault <jdufault@google.com> Date: Thu Feb 16 19:13:02 2017 cros: Fix various small issues with cast tray entry. 673023: Do not show TrayCast active state until we have media router information to prevent short visual glitch where we are "Casting to unknown receiver". 683908: Only show local routes 671094: Better accessibility label for Stop casting button. BUG=673023, 683908 , 671094 Review-Url: https://codereview.chromium.org/2656003006 Cr-Commit-Position: refs/heads/master@{#447045} (cherry picked from commit 461840ed16b4e886966d5bc44558668f8df382b7) Review-Url: https://codereview.chromium.org/2697363002 . Cr-Commit-Position: refs/branch-heads/2987@{#553} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/ash/ash_strings.grd [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/ash/common/system/chromeos/cast/tray_cast.cc [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/ash/common/system/chromeos/screen_security/screen_tray_item.h [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
,
Feb 17 2017
,
Jan 22 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by chrishtr@chromium.org
, Jan 23 2017