New issue
Advanced search Search tips

Issue 683905 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 632361



Sign in to add a comment

NoStatePrefetch: use NavigationThrottle to save a thread hop early on prefetch start

Project Member Reported by pasko@chromium.org, Jan 23 2017

Issue description

Discussion:

clamy ==>
It avoids a thread hop. On normal navigations I would very much argue that this is needed since it's on the critical path. In the prefetch case, not having the NavigationThrottle might just make the prefetch a bit slower to start.

droger ==>
Is the idea to move code from the PrerenderResourceThrottle to a NavigationThrottle?

If so, I'm not convinced there is much we can do, since our ResourceThrottle works on all resources, not only the navigation.

Or maybe the idea is not to move the code, but rather to share the code between ResourceThrottle and NavigationThrottle, so that they essentially do the same thing, but one works on subresources and the other on main resources?

clamy ==>
Yes that's the idea. You keep the ResourceThrottle for subresources & add a NavigationThrottle for main resources. As I mention this is a performance optimization that may make less sense on the prefetch though.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by pasko@chromium.org, Feb 12 2018

Status: Archived (was: Untriaged)

Sign in to add a comment