PingLoader should not use the per-frame task queue |
||||||||
Issue descriptionThis could cause hanging posts, where the objects timeout is never reached.
,
Jan 23 2017
Requesting a merge to M57 because this change landed before branch point.
,
Jan 23 2017
Is this change applicable to All OSs or any specific OS?
,
Jan 23 2017
All OS except iOS.
,
Jan 23 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2017
Change listed at #1 is not yet baked in Canary. Please wait until change is well baked in Canary and update Canary result here so we can approve merge to M57. Thank you.
,
Jan 25 2017
csharrison@, how is the revert looking in Canary?
,
Jan 25 2017
It is looking fine.
,
Jan 25 2017
Approving merge to M57 branch 2987 based on comment #8. Please merge ASAP. Thank you.
,
Jan 25 2017
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2d32dbc7514e959b3dd4c8b739a13d3f6d80a7b commit d2d32dbc7514e959b3dd4c8b739a13d3f6d80a7b Author: csharrison <csharrison@chromium.org> Date: Wed Jan 25 18:28:18 2017 Revert of Use TaskRunnerTimer in PingLoader (patchset #1 id:1 of https://codereview.chromium.org/2646523002/ ) Reason for revert: Pingloader should have its timeout persist after frame destruction. Original issue's description: > Use TaskRunnerTimer in PingLoader > > Blocker for the per-frame scheduler. > > BUG= 624694 > > Review-Url: https://codereview.chromium.org/2646523002 > Cr-Commit-Position: refs/heads/master@{#444627} > Committed: https://chromium.googlesource.com/chromium/src/+/81f01201993a78e1c89d70f11bc90b636a53cc99 TBR=yhirano@chromium.org, kinuko@chromium.org BUG= 624694 , 683900 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2654463002 Cr-Commit-Position: refs/heads/master@{#445380} (cherry picked from commit 49db2761173c14255f053871fb0b862dcf57fda3) Review-Url: https://codereview.chromium.org/2652253003 Cr-Commit-Position: refs/branch-heads/2987@{#91} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/d2d32dbc7514e959b3dd4c8b739a13d3f6d80a7b/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/d2d32dbc7514e959b3dd4c8b739a13d3f6d80a7b/third_party/WebKit/Source/core/loader/PingLoader.h
,
Jan 25 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2017