Issue 683890 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mastiz@chromium.org
Closed:	Jun 2017
Cc:	█ sfiera@chromium.org █ ramyan@chromium.org
Components:	UI>Browser>NewTabPage
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Remove code in ntp_tiles that deletes old Popular Sites cache

Project Member Reported by mastiz@chromium.org, Jan 23 2017

Issue description

Older versions of Chrome stored a cached version of Popular Sites in a local file. This has changed since, but there's code that deletes the file, for users that upgraded to a more recent version of Chrome.

After a few milestones (e.g. M61), this cleanup code should be removed (most clients should have upgraded).

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7

commit b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7
Author: fhorschig <fhorschig@chromium.org>
Date: Fri Jun 23 20:03:08 2017

Remove legacy popular sites cache cleaning

The cache cleaner is not necessary for recent Chromium versions anymore.
By removing this now, we also clean the deprecated call for a blocking
worker pool.

BUG= 683890 ,  667892 

Review-Url: https://codereview.chromium.org/2946143002
Cr-Commit-Position: refs/heads/master@{#481997}

[modify] https://crrev.com/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
[modify] https://crrev.com/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7/components/ntp_tiles/popular_sites_impl.h
[modify] https://crrev.com/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7/components/ntp_tiles/popular_sites_impl_unittest.cc
[modify] https://crrev.com/b8b9c6efcf9a97db1177fe3cdd3b02bc4d396aa7/ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc

Comment 2 by fhorschig@google.com, Jun 23 2017

Status: Fixed (was: Assigned)

►

Issue 683890 link

Issue metadata

Remove code in ntp_tiles that deletes old Popular Sites cache

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

Comment 1 Deleted

Comment 2 by fhorschig@google.com, Jun 23 2017

Comment 2 Deleted

Sign in to add a comment