execCommand insertText not working on Chrome Dev 57.0.2986.0 for multiline text |
|||||||||||||
Issue descriptionChrome Version: 57.0.2986.0 (Official Build) dev (64-bit) OS: Windows7, OSX-10.12.2, Ubuntu 14.04 What steps will reproduce the problem? (1)Open attached insertText.html in Chrome Dev 57.0.2986.0 (2)Click on "InsertText" button What is the expected result? It should paste text "SampleText" twice on separate lines. Works correctly on Chrome stable. What happens instead? It pastes Text "SampleText" only once followed by empty line.
,
Feb 1 2017
Hi Antony - do you know who would be good to take a look at this? Thx!
,
Feb 1 2017
,
Feb 1 2017
+Krishna, who owns 57.
,
Feb 1 2017
+ Prudhvi, could you please bisect and find an owner for this.
,
Feb 1 2017
Please find the bisect result below : You are probably looking for a change made after 438489 (known good), but no lat er than 438490 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/afdef36fb3116c5b6e07a5727bf9ee42e690ed4e..ef5c846a3e5d3c994d962ddca7d40f4bc1476044
,
Feb 7 2017
Able to reproduce this issue on Mac 10.12.2 using chrome latest Canary M58-58.0.3005.2 yabinh@ Ping! Could you please let us know is there any latest update available on this issue? Thanks!
,
Feb 7 2017
I have a CL on this. See https://codereview.chromium.org/2680733002/
,
Feb 8 2017
Removing the Needs-Bisect label as Bisect is already provided in comment # 6.
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/286c2ce88f848617aff81090e9cc41afdf5de7e5 commit 286c2ce88f848617aff81090e9cc41afdf5de7e5 Author: yabinh <yabinh@chromium.org> Date: Wed Feb 08 06:14:54 2017 Make Blink support multiline text insertion When inserting multiline text, Blink will insert the text before '\n' and the text after the '\n' separately, e.g., for "hello\nworld", Blink will insert "hello", then a paragraph separator, then "world". However, after inserting "hello", the text is updated to "hello" incorrectly, so the remaining "world" will not be inserted. This CL moves the text-updating logic to upper level to make it right. Besides, this CL adjusts the selection after each insertion for incremental insertion. BUG= 683885 Review-Url: https://codereview.chromium.org/2680733002 Cr-Commit-Position: refs/heads/master@{#448920} [modify] https://crrev.com/286c2ce88f848617aff81090e9cc41afdf5de7e5/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp [modify] https://crrev.com/286c2ce88f848617aff81090e9cc41afdf5de7e5/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp [modify] https://crrev.com/286c2ce88f848617aff81090e9cc41afdf5de7e5/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
,
Feb 8 2017
Adding Merge-Request-57 so that it triggers the approval process.
,
Feb 8 2017
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Feb 8 2017
Assigning to myself to track merge.
,
Feb 9 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2017
Tested on Win7/58.0.3007.0 (Official Build) canary (64-bit). Displaying "SampleText" twice on separate lines. Please merge your change to M57 branch 2987 before 5:00 PM PT, Friday 02/10 (sooner the better please) so we can take it in for next week beta release. Thank you.
,
Feb 9 2017
Please merge your change to M57 branch 2987 before 5:00 PM PT, Friday 02/10 so we can take it in for next week beta release. Thank you.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e commit 51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e Author: Alexandre Elias <aelias@chromium.org> Date: Thu Feb 09 23:20:40 2017 Make Blink support multiline text insertion When inserting multiline text, Blink will insert the text before '\n' and the text after the '\n' separately, e.g., for "hello\nworld", Blink will insert "hello", then a paragraph separator, then "world". However, after inserting "hello", the text is updated to "hello" incorrectly, so the remaining "world" will not be inserted. This CL moves the text-updating logic to upper level to make it right. Besides, this CL adjusts the selection after each insertion for incremental insertion. BUG= 683885 Review-Url: https://codereview.chromium.org/2680733002 Cr-Commit-Position: refs/heads/master@{#448920} (cherry picked from commit 286c2ce88f848617aff81090e9cc41afdf5de7e5) Review-Url: https://codereview.chromium.org/2691433002 . Cr-Commit-Position: refs/branch-heads/2987@{#422} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp [modify] https://crrev.com/51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp [modify] https://crrev.com/51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
,
Feb 9 2017
,
Feb 15 2017
Tested the issue on Windows-7, Mac-10.12.2 and Linux Ubuntu-14.04 using 57.0.2987.54 as per the comment#0. Observed that the fix is working as expected. Attaching screen cast for reference . Hence,adding the verified labels. Thanks. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by hlo@chromium.org
, Jan 25 2017