Enrolling with invalid AD user name crashes |
|||
Issue description[28096:28096:0123/125425.933251:FATAL:gaia_auth_util.cc(31)] Check failed: false. expecting exactly one @, but got 0 : a #0 0x7f38dda3fe4e base::debug::StackTrace::StackTrace() #1 0x7f38dda61afa logging::LogMessage::~LogMessage() #2 0x7f38de6e4b1f gaia::(anonymous namespace)::CanonicalizeEmailImpl() #3 0x7f38de6e4f6e gaia::ExtractDomainName() #4 0x7f38e0323e2e chromeos::EnrollmentScreenHandler::HandleAdDomainJoin() #5 0x7f38de8fd5fe _ZN4base8internal13FunctorTraitsIMN10extensions11ViscaWebcamEFvRKNS_8CallbackIFvbRKSt6vectorIcSaIcEEELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEES9_NS2_3api6serial12ReceiveErrorEEvE6InvokeIRKNS_7WeakPtrIS3_EEJSF_S9_SI_EEEvSK_OT_DpOT0_ #6 0x7f38d9c6550f chromeos::FakeAuthPolicyClient::JoinAdDomain() #7 0x7f38e0323ce0 chromeos::EnrollmentScreenHandler::OnPasswordPipeReady() #8 0x7f38e011754c _ZN4base8internal13FunctorTraitsIMN8chromeos17GaiaScreenHandlerEFvRKSsRKNS2_3KeyENS_13ScopedGenericIiNS0_19ScopedFDCloseTraitsEEEEvE6InvokeIRKNS_7WeakPtrIS3_EEJS5_S8_SB_EEEvSD_OT_DpOT0_ #9 0x7f38deb6b4a4 base::internal::ReplyAdapter<>() #10 0x7f38ddad5367 base::(anonymous namespace)::PostTaskAndReplyRelay::RunReplyAndSelfDestruct() #11 0x7f38dda409fe base::debug::TaskAnnotator::RunTask() #12 0x7f38dda6eb4d base::MessageLoop::RunTask() #13 0x7f38dda6f465 base::MessageLoop::DoWork() #14 0x7f38dda714aa base::(anonymous namespace)::WorkSourceDispatch() #15 0x7f38d6488e04 g_main_context_dispatch #16 0x7f38d6489048 <unknown> #17 0x7f38d64890ec g_main_context_iteration #18 0x7f38dda71276 base::MessagePumpGlib::Run() #19 0x7f38dda6e8c7 base::MessageLoop::RunHandler() #20 0x7f38ddaa188f base::RunLoop::Run() #21 0x7f38defb62b9 ChromeBrowserMainParts::MainMessageLoopRun() #22 0x7f38db2cbc19 content::BrowserMainLoop::RunMainMessageLoopParts() #23 0x7f38db2cf14a content::BrowserMainRunnerImpl::Run() #24 0x7f38db2c6e8e content::BrowserMain() #25 0x7f38dba5943c content::ContentMainRunnerImpl::Run() #26 0x7f38dba57f30 content::ContentMain() #27 0x7f38de6c6280 ChromeMain #28 0x7f38d3834f45 __libc_start_main #29 0x7f38de6c60dd <unknown>
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b69dd7f422f29571bfd72da3d452a3580f33d79 commit 9b69dd7f422f29571bfd72da3d452a3580f33d79 Author: rsorokin <rsorokin@chromium.org> Date: Fri Jan 27 12:31:04 2017 Check username validity in the FakeAuthPolicyClient BUG= 683878 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2653913002 Cr-Commit-Position: refs/heads/master@{#446650} [modify] https://crrev.com/9b69dd7f422f29571bfd72da3d452a3580f33d79/chrome/browser/resources/chromeos/login/offline_ad_login.js [modify] https://crrev.com/9b69dd7f422f29571bfd72da3d452a3580f33d79/chromeos/chromeos.gyp [modify] https://crrev.com/9b69dd7f422f29571bfd72da3d452a3580f33d79/chromeos/dbus/fake_auth_policy_client.cc [add] https://crrev.com/9b69dd7f422f29571bfd72da3d452a3580f33d79/chromeos/dbus/fake_auth_policy_client_unittest.cc
,
Jan 27 2017
,
Jul 6 2017
bulk Verify of older or not-user-facing Chromad bugs |
|||
►
Sign in to add a comment |
|||
Comment 1 by rsorokin@chromium.org
, Jan 24 2017