Clear LanguageModel when full history is removed from the browsing data. |
||||||
Issue descriptionCurrently, LanguageModel does not react to clearing browsing data in any way. The model does not support partial data removal well (as history entries are not annotated with the detected language). For M57, we should clear the model if complete history is to be cleared (needs to be merged).
,
Jan 30 2017
Verified on Canary 58.0.2994.3. The merge is needed because it is a privacy sensitive bug.
,
Jan 30 2017
Is this change applicable to all OSes or any specific OS?
,
Jan 30 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 30 2017
This change is applicable to all OSes. Thanks!
,
Jan 30 2017
,
Jan 30 2017
Please merge your change to M57 branch 2987 ASAP.If merge happens today before 5:00 PM PT, then we can take it for tomorrow's last M57 Dev release. Thank you.
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e297e01a5092bc072d897cba9309af7c35a9910 commit 1e297e01a5092bc072d897cba9309af7c35a9910 Author: jkrcal <jkrcal@chromium.org> Date: Mon Jan 30 21:41:06 2017 [LanguageModel] Clear the model when clearing full history Before this CL, the LanguageModel did not react in any way to user clearing browsing data. This CL adds wiping the model whenever the user clears the complete browsing history. TBR=groby NOTRY=true NOPRESUBMIT=true BUG= 683875 Review-Url: https://codereview.chromium.org/2649163003 Cr-Commit-Position: refs/heads/master@{#446350} Committed: https://chromium.googlesource.com/chromium/src/+/afb5fba70d41e1cc8971942d1d78cffa491933a0 (cherry picked from commit afb5fba70d41e1cc8971942d1d78cffa491933a0) Review-Url: https://codereview.chromium.org/2662783003 Cr-Commit-Position: refs/branch-heads/2987@{#189} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/chrome/browser/browsing_data/browsing_data_remover_unittest.cc [modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/components/translate/core/browser/language_model.cc [modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/components/translate/core/browser/language_model.h [modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/components/translate/core/browser/language_model_unittest.cc
,
Apr 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 26 2017