New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683875 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clear LanguageModel when full history is removed from the browsing data.

Project Member Reported by jkrcal@chromium.org, Jan 23 2017

Issue description

Currently, LanguageModel does not react to clearing browsing data in any way. The model does not support partial data removal well (as history entries are not annotated with the detected language).

For M57, we should clear the model if complete history is to be cleared (needs to be merged).
 

Comment 2 by jkrcal@chromium.org, Jan 30 2017

Labels: Merge-Request-57
Status: Verified (was: Started)
Verified on Canary 58.0.2994.3.

The merge is needed because it is a privacy sensitive bug.

Comment 3 by gov...@chromium.org, Jan 30 2017

Is this change applicable to all OSes or any specific OS?
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by jkrcal@chromium.org, Jan 30 2017

This change is applicable to all OSes.

Thanks!

Comment 6 by gov...@chromium.org, Jan 30 2017

Labels: OS-All

Comment 7 by gov...@chromium.org, Jan 30 2017

Please merge  your change to M57 branch 2987 ASAP.If merge happens today before 5:00 PM PT, then we can take it for tomorrow's last M57 Dev release. Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 30 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e297e01a5092bc072d897cba9309af7c35a9910

commit 1e297e01a5092bc072d897cba9309af7c35a9910
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Jan 30 21:41:06 2017

[LanguageModel] Clear the model when clearing full history

Before this CL, the LanguageModel did not react in any way to user
clearing browsing data.

This CL adds wiping the model whenever the user clears the complete
browsing history.

TBR=groby
NOTRY=true
NOPRESUBMIT=true
BUG= 683875 
Review-Url: https://codereview.chromium.org/2649163003
Cr-Commit-Position: refs/heads/master@{#446350}
Committed: https://chromium.googlesource.com/chromium/src/+/afb5fba70d41e1cc8971942d1d78cffa491933a0
(cherry picked from commit afb5fba70d41e1cc8971942d1d78cffa491933a0)

Review-Url: https://codereview.chromium.org/2662783003
Cr-Commit-Position: refs/branch-heads/2987@{#189}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
[modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/components/translate/core/browser/language_model.cc
[modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/components/translate/core/browser/language_model.h
[modify] https://crrev.com/1e297e01a5092bc072d897cba9309af7c35a9910/components/translate/core/browser/language_model_unittest.cc

Components: -UI>Browser>Translate UI>Browser>Language>Translate

Sign in to add a comment