New issue
Advanced search Search tips

Issue 683866 link

Starred by 1 user
Status: Verified
Owner:
aga...@chromium.org
Closed: Jan 2017
Cc:
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

AutoSetupSlaves's auto_reboot depends on configuration order

Project Member Reported by machenb...@chromium.org, Jan 23 2017 
If builders share a slave and one wants to auto-reboot, but the others don't, the semantics isn't clear.

In fact, auto-reboot will depend on the order of builders in the config file.

Uploaded regression test here:
https://chromium-review.googlesource.com/c/430652/

Comment 1 by aga...@chromium.org, Jan 27 2017

Components: -Infra
Owner: aga...@chromium.org
Status: Started (was: Untriaged)
I uploaded a fix to your regression test CL. PTAL.

Comment 2 by machenb...@chromium.org, Jan 30 2017 

And I commented on your change in my CL :) Who should give +1 in the end?

Comment 3 by aga...@chromium.org, Jan 30 2017

Status: Fixed (was: Started)
I think we got to an agreeable state :) Pair programming for the win!

Comment 4 by machenb...@chromium.org, Jan 30 2017

Status: Verified (was: Fixed)
\o/
►

Sign in to add a comment