New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683858 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird focus highlight is seen on radio button of popup blocked icon

Reported by dmascare...@etouch.net, Jan 23 2017

Issue description

Chrome Version:58.0.2990.0 (Official Build) 666e4f0298298427d2026c2896466951f199f5bf-refs/heads/master@{#445313}
OS: Windows (7,8,10), Linux

Pre-condition: Enable 'Material Design in the rest of the browser's native UI' flag

What steps will reproduce the problem?
1. Launch chrome and navigate to http://www.popuptest.com/popuptest1.html
2. Click on blocked popup icon present in omnibox, click on radio button and 
3. observe focus on radio button while clicking.

Actual: Weird focus highlight is seen on radio button while clicking on it.
Expected:Focus highlight of radio button should be proper.

This is regression issue, broken in 'M 57' and below is manual bisect:
Good build:57.0.2977.0
Bad build:57.0.2978.0

Note: Issue is not seen on Mac Os.

 
Bubble.png
147 KB View Download
Labels: -Pri-2 hasbisect-per-revision Pri-1
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on windows 10, Linux Ubuntu 14.04 with Chrome Canary.

Manual Bisect:
------------
Bad Build—57.0.2978.0--Revision-442756

Good Build—57.0.2977.0--Revision-442447

Bisect Tool Info:
-------------------
You are probably looking for a change made after 442682 (known good), but no later than 442683 (first known bad).

CHANGELOG URL:
---------------
The script might not always return single CL as suspectas some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/e5410705426f111d9ea78d121b70cb87ddf38187..44ec2a4fd5e1c052077575f84b5b5cbdb703cef6

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/44ec2a4fd5e1c052077575f84b5b5cbdb703cef6

Review-Url: 
-----------
https://codereview.chromium.org/2571613002

kylixrd@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!
Material mode dictates that the radio button is 16px from the left edge of the dialog.

Comment 3 by ajha@chromium.org, Feb 20 2017

Gentle ping to get an update on this.
kylixrd@,
Friendly ping!!
Still we are able to reproduce the issue on latest Canary-58.0.3026.0. Could you please look into this & update the thread accordingly.
Thank you!

Still able to reproduce this issue on Win-7 using latest canary #59.0.3046.0 

kylixrd@ - Gentle Ping...!!

Could you please have a look into this issue.

Thanks...!!

Cc: -nyerramilli@chromium.org kylixrd@chromium.org pkasting@chromium.org
Owner: bettes@chromium.org
Re-Assigned to bettes@ to get official take on how highlights should be handled under MD in this instance.
Cc: nyerramilli@chromium.org
Cc: bsep@chromium.org
Does this still occur?  I thought Bret just ripped out this behavior.

Comment 9 by bsep@chromium.org, Jun 19 2017

I think the bug is about the radio button highlight being too cut off on the left side. But you're right that there shouldn't be that big highlight in the first place. I fixed it for checkboxes, but it'd be pretty easy to recreate for radio buttons:

std::unique_ptr<InkDrop> Checkbox::CreateInkDrop() {
  // Completely removes the highlight.
  std::unique_ptr<InkDropImpl> ink_drop = CreateDefaultInkDropImpl();
  ink_drop->SetShowHighlightOnHover(false);
  ink_drop->SetAutoHighlightMode(views::InkDropImpl::AutoHighlightMode::NONE);
  return ink_drop;
}
Ah, so the "fix" is to remove the hover highlight altogether. That seems simple. Is this true of all controls under MD that also have an ink-drop?
I wonder whether we really want to entirely remove all highlight/focus/active feedback from these.  That seems like maybe going too far.
By doing what bsep@ proposed, there is no longer any keyboard focus indicator when tabbing through a dialog/popup with a checkbox or radio button. There is the AutoHighlightMode::HIDE_ON_RIPPLE mode, which may solve that issue. <shrug>
Owner: bsep@chromium.org
>> Actual: Weird focus highlight is seen on radio button while clicking on it.
>> Expected:Focus highlight of radio button should be proper.

The "weird focus" seems to be referring to the ripple. The ripple on the component is WAI for Views. MacViews should not have any ripples. 

This expected design is outlined below. Let me know if you need any more clarification.
https://docs.google.com/document/d/18yssJKsC5DTNfh7DtdL8o6m3RZroTrkuyJMGq36-Uf8/edit


It's the way the ripple is blended with the highlight underneath it.
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3fb693eb7384259d24c3f5f3835c428860aa6f6

commit a3fb693eb7384259d24c3f5f3835c428860aa6f6
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Jun 27 20:32:19 2017

Fix radio button focus behavior in Harmony.

When the radio button was focused with the tab key, the ink drop ripple
would activate. In addition when the radio button was clicked it would
get a focus ring. This patch fixes both of these things.

Bug:  683858 
Change-Id: Ia9f1e672d2d5a51414a6f7db0dc46addd58f398f
Reviewed-on: https://chromium-review.googlesource.com/547075
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482735}
[modify] https://crrev.com/a3fb693eb7384259d24c3f5f3835c428860aa6f6/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/a3fb693eb7384259d24c3f5f3835c428860aa6f6/ui/views/controls/button/radio_button.h

Comment 17 by abom...@etouch.net, Jul 18 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3159.5
Note: Above issue is fixed on latest Dev version 61.0.3159.5 on Windows and Linux OS

Thanks you.

Comment 18 by abom...@etouch.net, Jul 18 2017

Note: Above issue is fixed on latest Dev version 61.0.3159.5 on Windows and Linux OS

Thanks you.

Comment 19 by abom...@etouch.net, Jul 18 2017

Please find the attachment.
Actual_popradio.mp4
919 KB View Download

Comment 20 by bsep@chromium.org, Aug 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment