Issue metadata
Sign in to add a comment
|
Regression: Weird focus highlight is seen on radio button of popup blocked icon
Reported by
dmascare...@etouch.net,
Jan 23 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:58.0.2990.0 (Official Build) 666e4f0298298427d2026c2896466951f199f5bf-refs/heads/master@{#445313} OS: Windows (7,8,10), Linux Pre-condition: Enable 'Material Design in the rest of the browser's native UI' flag What steps will reproduce the problem? 1. Launch chrome and navigate to http://www.popuptest.com/popuptest1.html 2. Click on blocked popup icon present in omnibox, click on radio button and 3. observe focus on radio button while clicking. Actual: Weird focus highlight is seen on radio button while clicking on it. Expected:Focus highlight of radio button should be proper. This is regression issue, broken in 'M 57' and below is manual bisect: Good build:57.0.2977.0 Bad build:57.0.2978.0 Note: Issue is not seen on Mac Os.
,
Jan 25 2017
Material mode dictates that the radio button is 16px from the left edge of the dialog.
,
Feb 20 2017
Gentle ping to get an update on this.
,
Mar 1 2017
kylixrd@, Friendly ping!! Still we are able to reproduce the issue on latest Canary-58.0.3026.0. Could you please look into this & update the thread accordingly. Thank you!
,
Mar 21 2017
Still able to reproduce this issue on Win-7 using latest canary #59.0.3046.0 kylixrd@ - Gentle Ping...!! Could you please have a look into this issue. Thanks...!!
,
Jun 19 2017
Re-Assigned to bettes@ to get official take on how highlights should be handled under MD in this instance.
,
Jun 19 2017
,
Jun 19 2017
Does this still occur? I thought Bret just ripped out this behavior.
,
Jun 19 2017
I think the bug is about the radio button highlight being too cut off on the left side. But you're right that there shouldn't be that big highlight in the first place. I fixed it for checkboxes, but it'd be pretty easy to recreate for radio buttons:
std::unique_ptr<InkDrop> Checkbox::CreateInkDrop() {
// Completely removes the highlight.
std::unique_ptr<InkDropImpl> ink_drop = CreateDefaultInkDropImpl();
ink_drop->SetShowHighlightOnHover(false);
ink_drop->SetAutoHighlightMode(views::InkDropImpl::AutoHighlightMode::NONE);
return ink_drop;
}
,
Jun 19 2017
Ah, so the "fix" is to remove the hover highlight altogether. That seems simple. Is this true of all controls under MD that also have an ink-drop?
,
Jun 19 2017
I wonder whether we really want to entirely remove all highlight/focus/active feedback from these. That seems like maybe going too far.
,
Jun 21 2017
By doing what bsep@ proposed, there is no longer any keyboard focus indicator when tabbing through a dialog/popup with a checkbox or radio button. There is the AutoHighlightMode::HIDE_ON_RIPPLE mode, which may solve that issue. <shrug>
,
Jun 21 2017
>> Actual: Weird focus highlight is seen on radio button while clicking on it. >> Expected:Focus highlight of radio button should be proper. The "weird focus" seems to be referring to the ripple. The ripple on the component is WAI for Views. MacViews should not have any ripples. This expected design is outlined below. Let me know if you need any more clarification. https://docs.google.com/document/d/18yssJKsC5DTNfh7DtdL8o6m3RZroTrkuyJMGq36-Uf8/edit
,
Jun 22 2017
It's the way the ripple is blended with the highlight underneath it.
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3fb693eb7384259d24c3f5f3835c428860aa6f6 commit a3fb693eb7384259d24c3f5f3835c428860aa6f6 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jun 27 20:32:19 2017 Fix radio button focus behavior in Harmony. When the radio button was focused with the tab key, the ink drop ripple would activate. In addition when the radio button was clicked it would get a focus ring. This patch fixes both of these things. Bug: 683858 Change-Id: Ia9f1e672d2d5a51414a6f7db0dc46addd58f398f Reviewed-on: https://chromium-review.googlesource.com/547075 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#482735} [modify] https://crrev.com/a3fb693eb7384259d24c3f5f3835c428860aa6f6/ui/views/controls/button/radio_button.cc [modify] https://crrev.com/a3fb693eb7384259d24c3f5f3835c428860aa6f6/ui/views/controls/button/radio_button.h
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41f2ef33b224d02dea11bc5212811b39cc3b1115 commit 41f2ef33b224d02dea11bc5212811b39cc3b1115 Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Jul 12 15:35:06 2017 Use a delegation to override FocusRing behavior for checkboxes and radio buttons. Bug: 706297 Bug: 683858 Change-Id: Ibb51dbacc26164ead556488da18fb322350fddff Reviewed-on: https://chromium-review.googlesource.com/546697 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485963} [modify] https://crrev.com/41f2ef33b224d02dea11bc5212811b39cc3b1115/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/41f2ef33b224d02dea11bc5212811b39cc3b1115/ui/views/controls/button/checkbox.h [modify] https://crrev.com/41f2ef33b224d02dea11bc5212811b39cc3b1115/ui/views/controls/button/radio_button.cc [modify] https://crrev.com/41f2ef33b224d02dea11bc5212811b39cc3b1115/ui/views/controls/button/radio_button.h [modify] https://crrev.com/41f2ef33b224d02dea11bc5212811b39cc3b1115/ui/views/controls/focus_ring.cc [modify] https://crrev.com/41f2ef33b224d02dea11bc5212811b39cc3b1115/ui/views/controls/focus_ring.h
,
Jul 18 2017
Note: Above issue is fixed on latest Dev version 61.0.3159.5 on Windows and Linux OS Thanks you.
,
Jul 18 2017
Note: Above issue is fixed on latest Dev version 61.0.3159.5 on Windows and Linux OS Thanks you.
,
Jul 18 2017
Please find the attachment.
,
Aug 23 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Jan 23 2017Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)