New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683849 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Fix SharedSampler to cope correctly with zero-thread processes.

Project Member Reported by tkonch...@chromium.org, Jan 23 2017

Issue description

wez@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2566423002   

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=673175

Thanks,
 
 

Comment 1 by w...@chromium.org, Jan 23 2017

Cc: afakhry@chromium.org stanisc@chromium.org
There haven't been automated tests for this since we're calling an OS API and expecting it to return data within certain constraints. All we could really do is add a test that synthesizes forms that that data might take and hope that the OS API doesn't start returning something else.

Comment 2 by w...@chromium.org, Jan 23 2017

Labels: M-58

Comment 3 by w...@chromium.org, Jan 29 2017

Status: Assigned (was: Available)

Comment 4 by w...@chromium.org, Feb 1 2017

Status: Started (was: Assigned)

Comment 6 by w...@chromium.org, Feb 5 2017

Status: Fixed (was: Started)

Sign in to add a comment